Fix .SortTokens() crash for states only seen inside a polymorphism - #142
Merged
Conversation
A state that never appears as its own unambiguous token -- only ever inside an ambiguous (polymorphic) token like "(12)" -- had no row in `mapping`, so `wholes` silently held 0 for it. Summing `wholes[x]` for the ambiguous token then produced 0 instead of a real combined code, corrupting the state count and crashing ExpectedLength()'s downstream tabulate/sample pipeline with a names<- length mismatch. Fixes #135 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.SortTokens()(R/Consistency.R) leftmappingat0for any single state that only ever appears inside an ambiguous/polymorphic token (e.g."(12)"), never on its own.wholes[x]then summed to0instead of a real combined code when remapping that ambiguous token, corrupting the effective state count and crashingExpectedLength()'s downstreamtabulate/samplepipeline (names<-length mismatch), whichConsistency()'srhicolumn depends on.Repro:
Fixes #135
Test plan
.SortTokens()unit test for a state with no whole-token rowExpectedLength()-level regression test reproducing the original crashtestthat::test_file("tests/testthat/test-Consistency.R"): 25/25 passspelling::spell_check_package(): cleanagent-check.ymlon this branch: PASS🤖 Generated with Claude Code