red-team: area 12 round 2026-08-04 — scope-coverage diff, routing-channel finding, rearrange.cpp header correction - #44
Merged
Conversation
…age diff run Rotation (11 mod 13)+1 = 12, sonnet (last visit yielded). Filed #41 (routing state is tier-only) and #42 (scope rows never diffed against the file tree). The scope-coverage diff flagged on 2026-07-03 and never run is now run: two subsystems, 5553 + 2183 loc, in no area at all. 17 files added to rows 1/2/4/5/6 inline, area 7 extended to the Shiny app tests, area 8 broadened from test-ts-*.R to tests/testthat/*.R (it excluded ~44 of ~110 files). Every addition annotated UNMEASURED, per this area's own lesson that a grown scope row inherits no dry verdict. Also corrected: README severity breakdown had drifted within the round it was written (6/5/13 vs a true 6/4/14) — replaced with a query; the undocumented area:N label dependency; a missing migration-map-todo.tsv row; and the "NEVER REVIEWED" rationales on areas 12 and 13, both stale. src/rearrange.cpp: header claimed "DEAD CODE ... Safe to remove" and was false. The Rcpp::export tags are commented out but RcppExports.cpp and TreeSearch-init.c were never regenerated, so nni/spr/spr_moves stay registered, bound at R/RcppExports.R:60-68 and exercised by three test files. Acting on the header breaks them. Comment corrected; no code change. Reverted a finder action: needs-escalation had been applied to #18/#19 for a backlog row whose ask is sequencing, not tier. Area 13 is already opus, and a label hit makes step 3 skip reading the row that holds the ask. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ms609
enabled auto-merge
August 4, 2026 17:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round record for the 2026-08-04 area-12 red-team round (process meta-review, sonnet / Sonnet 5).
No closing keywords. The two findings this round produced — #41 and
#42 — are restructuring decisions for you, not things this PR fixes. They
stay open deliberately.
What's in the diff
log.md— the round entry, andlast_focus: 11→12. The rotation pointer onlyadvances when this merges; until then a fresh
/red-teamre-runs area 12.focus-areas.md— 17 files added to rows 1/2/4/5/6, area 7 extended to the Shiny app's owntest suite, area 8's glob broadened from
test-ts-*.Rtotests/testthat/*.R(it had beenexcluding ~44 of ~110 test files). Every addition annotated UNMEASURED / no inherited
maturity, per this area's own standing lesson that a grown scope row inherits no dry verdict.
Also corrects the
start_tierrationales for areas 12 and 13, both of which still read"NEVER REVIEWED" despite rounds having run — area 13's since 2026-07-02, through two rounds
that reviewed it.
README.md— the hand-kept severity breakdown read 6/5/13 against a true 6/4/14, havingdrifted within the same round it was written, two lines above the file's own instruction not
to maintain it by hand; replaced with a query. Plus the undocumented
gh label create area:Ndependency, a missing
migration-map-todo.tsvrow, and a glob-case gotcha(
R/pp_info_extra_step.ris silently skipped byR/*.R).escalation-backlog.md— P1/P2 → sev: vocabulary on item 7, and an explicitdo-not-promote-this-row note explaining why (see below).
src/rearrange.cpp— comment only, no code change. Its header claimed "DEAD CODE … nofunctions are exported or called … Safe to remove" and that is false: the
[[Rcpp::export]]tags are commented out, butRcppExports.cppandTreeSearch-init.cwerenever regenerated, so
_TreeSearch_nni/_TreeSearch_spr/_TreeSearch_spr_movesremaindeclared and registered in the
callMethodstable, are bound atR/RcppExports.R:60-68, andare exercised by three test files. Acting on that header breaks them. Only
tbr_movesisgenuinely unexported.
One tracker change was made and then reverted
The finder labelled #18 and #19
needs-escalation, following the skill's promote-to-label rule.I reverted both; zero issues carry the label now, as before the round. That flag encodes only
"dispatch at
opus+", and area 13'sstart_tieris alreadyopus— but the real problem isthat step 3 treats a label hit as "no further reading needed for this check", so it would have
suppressed reading the backlog row that holds the actual ask (a sequencing decision, which that
row says in as many words). Generalised into #41.
Please read before dispatching the next round
Rotation reaches area 13 next, and area 13 carries a standing "NEXT VISIT: NOT another
finder — a BOUNDED EXHAUSTIVE HARNESS" verdict from 2026-07-03. Step 4 reads the entry
containing it; step 5 launches a finder regardless. This PR applies the only project-local
mitigation available — making the verdict unmissable in the rationale read at step 1 — but the
mechanical fix is a shared-skill edit, which is the decision in #41.
Checks
spelling::spell_check_package()— clean (0 errors), run with the same invocationtests/spelling.Ruses.agent-check.ymlrun 30908977215:ubuntu-arm64success,windowsfailure. The Windows failure is pre-existing andbranch-independent — it is in
Set up R dependencies, before anything compiles, becausepakcannot resolveMaxMin(Suggests:, noRemotes:field). An unrelated branch(
claude/treesearch-issue-38-8103cc,run 30908703022) fails
identically. Filed as agent-check.yml
windowsjob fails on every branch:MaxMinis not published in ms609.github.io/packages, so pak cannot resolve it #43 rather than buried here.Flagging the process consequence rather than quietly merging past it:
AGENTS.mdsays to opena PR "on GHA success", and right now no branch can reach that state. I have not treated a
red check as acceptable — I have shown it is not attributable to this diff. Merging is your
call; a docs-plus-one-comment change is about as safe as it gets, but agent-check.yml
windowsjob fails on every branch:MaxMinis not published in ms609.github.io/packages, so pak cannot resolve it #43 should be fixedbefore anything touching the kernels lands.
No local build was run: the only source change is a comment block, so there is no signature
change and
compile-attrs.Ris not triggered.🤖 Generated with Claude Code