Skip to content

red-team: area 12 round 2026-08-04 — scope-coverage diff, routing-channel finding, rearrange.cpp header correction - #44

Merged
ms609 merged 2 commits into
cpp-searchfrom
feature/redteam-area12
Aug 5, 2026
Merged

red-team: area 12 round 2026-08-04 — scope-coverage diff, routing-channel finding, rearrange.cpp header correction#44
ms609 merged 2 commits into
cpp-searchfrom
feature/redteam-area12

Conversation

@ms609

@ms609 ms609 commented Aug 4, 2026

Copy link
Copy Markdown

Round record for the 2026-08-04 area-12 red-team round (process meta-review, sonnet / Sonnet 5).

No closing keywords. The two findings this round produced — #41 and
#42 — are restructuring decisions for you, not things this PR fixes. They
stay open deliberately.

What's in the diff

  • log.md — the round entry, and last_focus: 1112. The rotation pointer only
    advances when this merges; until then a fresh /red-team re-runs area 12.
  • focus-areas.md — 17 files added to rows 1/2/4/5/6, area 7 extended to the Shiny app's own
    test suite, area 8's glob broadened from test-ts-*.R to tests/testthat/*.R (it had been
    excluding ~44 of ~110 test files). Every addition annotated UNMEASURED / no inherited
    maturity
    , per this area's own standing lesson that a grown scope row inherits no dry verdict.
    Also corrects the start_tier rationales for areas 12 and 13, both of which still read
    "NEVER REVIEWED" despite rounds having run — area 13's since 2026-07-02, through two rounds
    that reviewed it.
  • README.md — the hand-kept severity breakdown read 6/5/13 against a true 6/4/14, having
    drifted within the same round it was written, two lines above the file's own instruction not
    to maintain it by hand; replaced with a query. Plus the undocumented gh label create area:N
    dependency, a missing migration-map-todo.tsv row, and a glob-case gotcha
    (R/pp_info_extra_step.r is silently skipped by R/*.R).
  • escalation-backlog.md — P1/P2 → sev: vocabulary on item 7, and an explicit
    do-not-promote-this-row note explaining why (see below).
  • src/rearrange.cpp — comment only, no code change. Its header claimed "DEAD CODE … no
    functions are exported or called … Safe to remove"
    and that is false: the
    [[Rcpp::export]] tags are commented out, but RcppExports.cpp and TreeSearch-init.c were
    never regenerated, so _TreeSearch_nni / _TreeSearch_spr / _TreeSearch_spr_moves remain
    declared and registered in the callMethods table, are bound at R/RcppExports.R:60-68, and
    are exercised by three test files. Acting on that header breaks them. Only tbr_moves is
    genuinely unexported.

One tracker change was made and then reverted

The finder labelled #18 and #19 needs-escalation, following the skill's promote-to-label rule.
I reverted both; zero issues carry the label now, as before the round. That flag encodes only
"dispatch at opus+", and area 13's start_tier is already opus — but the real problem is
that step 3 treats a label hit as "no further reading needed for this check", so it would have
suppressed reading the backlog row that holds the actual ask (a sequencing decision, which that
row says in as many words). Generalised into #41.

Please read before dispatching the next round

Rotation reaches area 13 next, and area 13 carries a standing "NEXT VISIT: NOT another
finder — a BOUNDED EXHAUSTIVE HARNESS"
verdict from 2026-07-03. Step 4 reads the entry
containing it; step 5 launches a finder regardless. This PR applies the only project-local
mitigation available — making the verdict unmissable in the rationale read at step 1 — but the
mechanical fix is a shared-skill edit, which is the decision in #41.

Checks

🤖 Generated with Claude Code

…age diff run

Rotation (11 mod 13)+1 = 12, sonnet (last visit yielded). Filed #41 (routing
state is tier-only) and #42 (scope rows never diffed against the file tree).

The scope-coverage diff flagged on 2026-07-03 and never run is now run: two
subsystems, 5553 + 2183 loc, in no area at all. 17 files added to rows 1/2/4/5/6
inline, area 7 extended to the Shiny app tests, area 8 broadened from
test-ts-*.R to tests/testthat/*.R (it excluded ~44 of ~110 files). Every
addition annotated UNMEASURED, per this area's own lesson that a grown scope row
inherits no dry verdict.

Also corrected: README severity breakdown had drifted within the round it was
written (6/5/13 vs a true 6/4/14) — replaced with a query; the undocumented
area:N label dependency; a missing migration-map-todo.tsv row; and the
"NEVER REVIEWED" rationales on areas 12 and 13, both stale.

src/rearrange.cpp: header claimed "DEAD CODE ... Safe to remove" and was false.
The Rcpp::export tags are commented out but RcppExports.cpp and
TreeSearch-init.c were never regenerated, so nni/spr/spr_moves stay registered,
bound at R/RcppExports.R:60-68 and exercised by three test files. Acting on the
header breaks them. Comment corrected; no code change.

Reverted a finder action: needs-escalation had been applied to #18/#19 for a
backlog row whose ask is sequencing, not tier. Area 13 is already opus, and a
label hit makes step 3 skip reading the row that holds the ask.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@ms609
ms609 enabled auto-merge August 4, 2026 17:03
@ms609
ms609 disabled auto-merge August 5, 2026 03:04
@ms609
ms609 merged commit 174f65b into cpp-search Aug 5, 2026
5 of 6 checks passed
@ms609
ms609 deleted the feature/redteam-area12 branch August 5, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants