Reload atunnel client CA per handshake - #695
Open
Yang Haoran (0YHR0) wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Yang Haoran (0YHR0)
marked this pull request as ready for review
August 2, 2026 08:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #688
What changed
GetConfigForClient.Why
The server previously built
ClientCAsonly at startup. Long-lived workers therefore continued using stale CA material after the projected trust bundle rotated, rejecting newly valid router certificates and potentially retaining trust in the previous CA until restart.Impact
Client CA rotation now takes effect on the next TLS handshake. A missing or malformed rotated trust bundle fails that handshake instead of silently falling back to stale trust material.
Validation
go test -count=10 ./internal/atunnelgo vet ./internal/atunnelgit diff --checkmake verify(the changedinternal/atunnelpackage passes, but the full repository suite is not Windows-compatible: Linux-only syscalls such asFlock,SIGUSR1, andSEEK_DATA, plus symlink privilege requirements, fail on this host)Documentation changes are not needed because this fixes certificate rotation behavior without changing the public API or configuration.