fix(reasoning): honor configured summary mode#296
Open
duclvz wants to merge 1 commit into
Open
Conversation
Respect model_reasoning_summary from CODEX_CONFIG env for prompt turns while preserving compatibility guards and the default thinking stream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CODEX_CONFIG.model_reasoning_summarywhen starting prompt turns.auto,concise,detailed, andnone.nonefor API-key authentication and models without reasoning support.autoas the fallback so thinking chunks remain visible when no mode is configured.README.mdandreadme-dev.md.Problem
CodexAcpClient.sendPrompt()always sentsummary: "auto"for supported models. Becauseturn/start.summaryis a per-turn override, this replaced an explicit reasoning-summary mode supplied throughCODEX_CONFIG.Removing the field entirely also caused the default thinking block to disappear because no reasoning-summary chunks were emitted in the unconfigured production path.
Solution
Resolve the turn summary mode using this precedence:
noneCODEX_CONFIG.model_reasoning_summaryautoThis preserves existing behavior while allowing users to select a more specific summary mode.
Scope
This change reads
model_reasoning_summaryfromCODEX_CONFIG. It does not add separate resolution of~/.codex/config.toml.Testing
autoanddetailedruns both emitted ACP thought chunks and completed successfullyRefs #294