fix: honor CODEX_CONFIG reasoning summary per turn#298
Open
wpfleger96 wants to merge 1 commit into
Open
Conversation
sendPrompt() unconditionally set summary to "auto", overriding whatever the session config carried via CODEX_CONFIG. Read the configured value and pass it through; fall back to "auto" only when unset or invalid. disableSummary still forces "none" unconditionally. Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
4721882 to
2c4a2ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sendPrompt()unconditionally overrides the per-turn reasoning summary to"auto", so themodel_reasoning_summarykey inCODEX_CONFIG(which already flows into the session config) can never take effect. This is the same config-passthrough class as #280 and #215.The fix reads the configured value and passes it through to
runTurn. Falls back to"auto"when unset or invalid, preserving today's behavior exactly.disableSummary(API-key auth / model lacks reasoning) still forces"none"unconditionally.Closes #294