feat: add commander remote control toggle - #18
Merged
Conversation
Collaborator
Author
|
Windows deployment smoke on test machine
Conclusion: the button/API path starts and stops the daemon process, but end-to-end remote control on this test machine is blocked by Commander/observer auth ( |
Collaborator
Author
|
Claude Code rereview after fix ( P2/P3 recorded only per policy; not fixed in this PR pass: P2:
P3:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
远程控制panel in the commander dashboard with the Loom commander URL and a toggle for the local driver daemon./api/console/driver-daemonGET/POST endpoints with console-token, same-origin checks, body size limit, serialized mutations, and sanitized errors.Review Gates
REVIEW_DECISION: PASS,MAX_SEVERITY: P3; no P0/P1 findings.Test Plan
go test -count=1 ./...npm testininternal/ui/webnpm run buildininternal/ui/webGOOS=windows go test -count=1 -run '^$' ./internal/loomgit diff --checkDeployment Smoke
Administrator@9.0.16.110, and validate the远程控制button against the installed app.