[db] Add fsync support #1915

[michaelvlach]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
agdb	Ready	Preview	Aug 18, 2026 10:08am

[Copilot]

Pull request overview

This PR introduces explicit durability controls for the agdb storage layer by adding a SyncMode API and exposing synchronization controls on Db, enabling safer operation on filesystems where write ordering/flush behavior can break WAL expectations (e.g., some network filesystems).

Changes:

• Add SyncMode (default None, optional Commit) and plumb it through StorageData, Storage, and Db (set_sync_mode, sync_mode, sync).
• Implement commit-time syncing behavior for file-backed storage and add WAL sync support.
• Add documentation and a regression test covering the new DbFile sync API surface.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
agdb/tests/db_test.rs	Adds a test exercising DbFile::{sync,set_sync_mode,sync_mode}.
agdb/src/storage/write_ahead_log.rs	Adds WriteAheadLog::sync() to fdatasync the WAL file.
agdb/src/storage/file_storage.rs	Introduces sync_mode handling in flush(), adds sync(), and updates WAL-apply behavior.
agdb/src/storage/file_storage_memory_mapped.rs	Delegates new sync-related StorageData methods to the underlying FileStorage.
agdb/src/storage/any_storage.rs	Plumbs new sync-related StorageData methods through the AnyStorage enum.
agdb/src/storage.rs	Defines SyncMode and extends StorageData/Storage with sync-related APIs.
agdb/src/lib.rs	Re-exports SyncMode from the crate root.
agdb/src/db.rs	Exposes DbImpl::{sync,set_sync_mode,sync_mode} public API.
agdb_web/content/docs/01.guides/01.concepts.md	Documents SyncMode and when to enable commit syncing.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.