Return an empty turn response instead of failing - #67
Merged
Conversation
Run required assistant text, so a turn that answered with tool calls was reported to the caller as failed. agynd replayed the message and the agent sent its reply again on every attempt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The third and last place the same assumption lived — and the one that actually reaches agynd:
RunrequiredLastAssistant, so a turn that answered by callingSendMessagewas reported as failed. agynd replayed the message and the agent sent its reply again on every attempt.LastAssistantis now referenced in exactly one place (setting it), so there is no fourth copy of this. The two earlier fixes (#65model returned no content, #66no assistant response to save) only moved the failure one stage on each time.