chore: remove the ArgoCD sync dance - #30
Merged
Merged
Conversation
The selector paired app.kubernetes.io/name with app.kubernetes.io/instance=<service>. That held when each service was its own Helm release; the platform umbrella makes the instance label its own release name, so it matches nothing: DevSpace still couldn't find any Pods that match the selector The pod comes up and waits for a binary the sync never delivers, and the deploy times out having patched a Deployment it then cannot reach. The name label alone is unique in the namespace and holds either way.
ArgoCD is gone with bootstrap. Disabling its auto-sync before a source deploy and restoring it after has had nothing to disable or restore since the platform moved to the VM -- every run of it printed "Application not found" and carried on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArgoCD went away with bootstrap. Disabling its auto-sync before a source deploy and restoring it after has had nothing to disable or restore since the platform moved to the VM — every run printed
WARNING: ArgoCD Application not found in argocd namespaceand carried on.Removes the
disable_argocd_sync/restore_argocd_syncfunctions, their call sites, therestore-argocdpipeline and theafter:devhook.Part of removing the E2E workflow’s build-time source patches: three of them existed only to inject a "skip the ArgoCD restore in CI" branch into this file.