Skip to content

fix(platform): add ziti management dependency - #238

Merged
vitramir merged 5 commits into
mainfrom
noa/issue-237
Apr 5, 2026
Merged

fix(platform): add ziti management dependency#238
vitramir merged 5 commits into
mainfrom
noa/issue-237

Conversation

@casey-brooks

Copy link
Copy Markdown
Contributor

Summary

  • add ziti-management to agents-orchestrator dependencies

Testing

  • terraform fmt -recursive -check
  • ./apply.sh -y
  • ./.github/scripts/verify_platform_health.sh

Closes #237

@casey-brooks
casey-brooks requested a review from a team as a code owner April 4, 2026 22:11
@casey-brooks

Copy link
Copy Markdown
Contributor Author

Summary

  • add ziti-management to agents-orchestrator depends_on ordering

Testing

Commands:

  • ./apply.sh -y
  • ./.github/scripts/verify_platform_health.sh

Results:

  • Passed: 2
  • Failed: 0
  • Skipped: 0

Lint

  • terraform fmt -recursive -check (no errors)

noa-lucent
noa-lucent previously approved these changes Apr 4, 2026

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, single-line fix that matches the issue specification exactly.

  • argocd_application.ziti_management exists (line 3930) and is already referenced as a dependency by other downstream resources.
  • Placement in the depends_on list is consistent with existing style.
  • No extraneous changes.

LGTM.

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Summary

  • add ziti-management dependency for agents-orchestrator
  • bump users chart version to 0.4.1 in platform variables

Testing

Commands:

  • ./apply.sh -y
  • ./.github/scripts/verify_platform_health.sh

Results:

  • Passed: 2
  • Failed: 0
  • Skipped: 0

Lint

  • terraform fmt -recursive -check (no errors)

@rowan-stein

Copy link
Copy Markdown
Collaborator

Updated — also bumps users_chart_version to 0.4.1 (includes identity registration fix from users PR #14).

Changes now:

  1. Add ziti_management to agents-orchestrator depends_on
  2. Bump users chart to 0.4.1

Both needed to fix chat-app e2e failures.

noa-lucent
noa-lucent previously approved these changes Apr 5, 2026

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed after new commit.

  • main.tfziti_management depends_on addition is unchanged from prior approval. Still correct.
  • variables.tforganizations_chart_version 0.3.0 → 0.4.0 comes from the rebase onto main (PR #236). users_chart_version 0.3.0 → 0.4.1 is the net-new bump for the identity registration fix. Both are straightforward default-value changes with no structural impact.

One nit: PR description should be updated to mention the users chart bump.

LGTM.

type = string
description = "Version of the users Helm chart published to GHCR"
default = "0.3.0"
default = "0.4.1"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] The PR description ("Summary") still only mentions the ziti-management dependency. Now that users is bumped to 0.4.1 (identity registration fix), please update the description to reflect both changes so the merge commit / changelog is accurate.

@casey-brooks
casey-brooks dismissed noa-lucent’s stale review April 5, 2026 00:35

The merge-base changed after approval.

@vitramir
vitramir merged commit 4ac5eb9 into main Apr 5, 2026
1 check passed
casey-brooks added a commit that referenced this pull request Apr 27, 2026
* fix(platform): add ziti dependency

* chore(platform): bump chart versions (#236)

* fix(platform): add ziti dependency

* fix(platform): bump users chart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ziti_management to agents-orchestrator depends_on

4 participants