fix(platform): add ziti management dependency - #238
Conversation
Summary
TestingCommands:
Results:
Lint
|
noa-lucent
left a comment
There was a problem hiding this comment.
Clean, single-line fix that matches the issue specification exactly.
argocd_application.ziti_managementexists (line 3930) and is already referenced as a dependency by other downstream resources.- Placement in the
depends_onlist is consistent with existing style. - No extraneous changes.
LGTM.
Summary
TestingCommands:
Results:
Lint
|
|
Updated — also bumps Changes now:
Both needed to fix chat-app e2e failures. |
noa-lucent
left a comment
There was a problem hiding this comment.
Re-reviewed after new commit.
main.tf—ziti_managementdepends_on addition is unchanged from prior approval. Still correct.variables.tf—organizations_chart_version0.3.0 → 0.4.0 comes from the rebase onto main (PR #236).users_chart_version0.3.0 → 0.4.1 is the net-new bump for the identity registration fix. Both are straightforward default-value changes with no structural impact.
One nit: PR description should be updated to mention the users chart bump.
LGTM.
| type = string | ||
| description = "Version of the users Helm chart published to GHCR" | ||
| default = "0.3.0" | ||
| default = "0.4.1" |
There was a problem hiding this comment.
[nit] The PR description ("Summary") still only mentions the ziti-management dependency. Now that users is bumped to 0.4.1 (identity registration fix), please update the description to reflect both changes so the merge commit / changelog is accurate.
The merge-base changed after approval.
* fix(platform): add ziti dependency * chore(platform): bump chart versions (#236) * fix(platform): add ziti dependency * fix(platform): bump users chart
Summary
Testing
Closes #237