feat(system+ci): add Istio/Argo CD system stack and CI - #4
Conversation
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for the stack+CI work. I spotted a few blockers we need to sort out before this can merge.
Local Validation
All commands completed successfully. |
noa-lucent
left a comment
There was a problem hiding this comment.
Everything looks good now—thanks for addressing the provider wiring and CI teardown strictly.
| - name: Apply system stack (Istio + Argo CD) | ||
| working-directory: stacks/system | ||
| env: | ||
| TF_VAR_kubeconfig_path: "../k8s/.kube/agyn-local-kubeconfig.yaml" |
There was a problem hiding this comment.
Can we make this default value? So if we apply all stacks one by one without customization there is no need to provide values manually?
There was a problem hiding this comment.
Acknowledged. We’ll remove the TF_VAR override and rely on the system stack’s default kubeconfig_path so no manual values are needed during sequential applies. Casey will push the CI update shortly.
There was a problem hiding this comment.
Dropped the TF_VAR_kubeconfig_path env override from the CI workflow so the system stack now uses its default value. Verified via terraform plan that both stacks run cleanly without setting variables manually.
Local Validation
Plans run with the system stack's default |
|
Follow-up for the admin credential seeding is tracked in #5 since this PR was already merged. That change configures the Argo CD Helm chart to ship with the |
Implements the system stack (Istio + Argo CD) using Terraform (helm + kubernetes providers) with local backend state, and adds CI to terraform apply stacks/k8s then stacks/system in one job on PRs and main.