Skip to content

Fix platform-ui replica count - #81

Merged
vitramir merged 3 commits into
mainfrom
noa/issue-80
Mar 12, 2026
Merged

Fix platform-ui replica count#81
vitramir merged 3 commits into
mainfrom
noa/issue-80

Conversation

@casey-brooks

@casey-brooks casey-brooks commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • set platform-ui Helm values replicaCount to 1
  • set files Helm values replicaCount to 1
  • set agent-state Helm values replicaCount to 1
  • set token-counting Helm values replicaCount to 1

Testing

  • terraform fmt -check -recursive
  • terraform -chdir=stacks/platform validate

Refs #80

@casey-brooks
casey-brooks requested a review from a team as a code owner March 12, 2026 17:58
@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • terraform fmt -check -recursive (lint, no errors)
  • terraform -chdir=stacks/platform validate (passed)

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • terraform fmt -check -recursive (lint, no errors)
  • terraform -chdir=stacks/platform validate (passed: 1, failed: 0, skipped: 0)

noa-lucent
noa-lucent previously approved these changes Mar 12, 2026

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, minimal change that correctly resolves #80.

  • replicaCount = 1 added to platform_ui_values, matching the pattern used by platform_server_values and all other service blocks.
  • Placement at the top of the yamlencode block is consistent with the existing convention.
  • No extraneous changes.

LGTM.

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • terraform fmt -check -recursive (lint, no errors)
  • terraform -chdir=stacks/platform validate (passed: 1, failed: 0, skipped: 0)

noa-lucent
noa-lucent previously approved these changes Mar 12, 2026

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both changes look correct and well-formatted:

  • files_values (line 584): replicaCount = 1 — alignment matches the adjacent fullnameOverride, consistent with litellm_values and ncps_values.
  • platform_ui_values (line 1110): replicaCount = 1 — no alignment padding needed (next key is image block), consistent with platform_server_values.

Good catch adding files — the issue's specification overlooked that it was also missing replicaCount.

Note (non-blocking): agent_state_values and token_counting_values also lack an explicit replicaCount. If the goal from #80 is to pin all application services to 1 replica, those two should be addressed as well — either in this PR or a follow-up.

LGTM.

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • terraform fmt -check -recursive (lint, no errors)
  • terraform -chdir=stacks/platform validate (passed: 1, failed: 0, skipped: 0)

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All four additions are correct and well-formatted:

  • agent_state_values (line 557): replicaCount = 1 — aligned with fullnameOverride
  • token_counting_values (line 573): replicaCount = 1 — aligned with fullnameOverride
  • files_values (line 586): replicaCount = 1 — aligned with fullnameOverride
  • platform_ui_values (line 1112): replicaCount = 1 — no padding (next key is image block), matching platform_server_values

Every application service now explicitly sets replicaCount, while infrastructure/database blocks correctly remain without it. The non-blocking note from my previous review is fully addressed.

LGTM.

@vitramir
vitramir merged commit b99a5ad into main Mar 12, 2026
1 check passed
casey-brooks added a commit that referenced this pull request Apr 27, 2026
* fix(platform): set ui replica count

* fix(platform): set files replica count

* fix(platform): set grpc replica counts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants