Fix platform-ui replica count - #81
Conversation
Test & Lint Summary
|
Test & Lint Summary
|
noa-lucent
left a comment
There was a problem hiding this comment.
Clean, minimal change that correctly resolves #80.
replicaCount = 1added toplatform_ui_values, matching the pattern used byplatform_server_valuesand all other service blocks.- Placement at the top of the
yamlencodeblock is consistent with the existing convention. - No extraneous changes.
LGTM.
Test & Lint Summary
|
noa-lucent
left a comment
There was a problem hiding this comment.
Both changes look correct and well-formatted:
files_values(line 584):replicaCount = 1— alignment matches the adjacentfullnameOverride, consistent withlitellm_valuesandncps_values.platform_ui_values(line 1110):replicaCount = 1— no alignment padding needed (next key isimageblock), consistent withplatform_server_values.
Good catch adding files — the issue's specification overlooked that it was also missing replicaCount.
Note (non-blocking): agent_state_values and token_counting_values also lack an explicit replicaCount. If the goal from #80 is to pin all application services to 1 replica, those two should be addressed as well — either in this PR or a follow-up.
LGTM.
Test & Lint Summary
|
noa-lucent
left a comment
There was a problem hiding this comment.
All four additions are correct and well-formatted:
agent_state_values(line 557):replicaCount = 1— aligned withfullnameOverride✓token_counting_values(line 573):replicaCount = 1— aligned withfullnameOverride✓files_values(line 586):replicaCount = 1— aligned withfullnameOverride✓platform_ui_values(line 1112):replicaCount = 1— no padding (next key isimageblock), matchingplatform_server_values✓
Every application service now explicitly sets replicaCount, while infrastructure/database blocks correctly remain without it. The non-blocking note from my previous review is fully addressed.
LGTM.
* fix(platform): set ui replica count * fix(platform): set files replica count * fix(platform): set grpc replica counts
Summary
Testing
Refs #80