Skip to content

feat(tracing-app): add claude full-chain - #61

Merged
rowan-stein merged 2 commits into
mainfrom
noa/issue-60
Apr 26, 2026
Merged

feat(tracing-app): add claude full-chain#61
rowan-stein merged 2 commits into
mainfrom
noa/issue-60

Conversation

@casey-brooks

@casey-brooks casey-brooks commented Apr 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add Claude full-chain TestLLM/protocol/init image support in tracing helper
  • add Claude message deep link full-chain spec
  • document CLAUDE_INIT_IMAGE default
  • forward CLAUDE_INIT_IMAGE into suite runner env

Testing

  • npx eslint . --config eslint.config.js
  • E2E_BASE_URL=https://tracing.agyn.dev npx playwright test (fails: connect ECONNREFUSED 127.0.0.1:443 for /env.js)

Closes #60

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • npx eslint . --config eslint.config.js (no errors)
  • E2E_BASE_URL=https://tracing.agyn.dev npx playwright test (failed: connect ECONNREFUSED 127.0.0.1:443 for /env.js; 0 passed, 5 failed, 0 skipped)

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude full-chain coverage looks on track (new helper support + new Playwright spec).

Requested changes:

  • Please wire CLAUDE_INIT_IMAGE through the suite runner (scripts/run-pipeline.sh) so the README-documented override actually works when running via devspace run test-e2e.

Non-blocking:

  • Consider making the “no spans” failure message SDK-aware (it currently references codex).
  • Consider switching Refs #60Closes #60 to auto-close on merge.

Comment thread README.md
Comment thread suites/playwright-tracing-app/test/e2e/tracing-run.ts
@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • npx eslint . --config eslint.config.js (no errors)
  • E2E_BASE_URL=https://tracing.agyn.dev npx playwright test (failed: connect ECONNREFUSED 127.0.0.1:443 for /env.js; 0 passed, 5 failed, 0 skipped)

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review: changes requested are addressed.

  • CLAUDE_INIT_IMAGE is now forwarded through scripts/run-pipeline.sh, so the documented override works with devspace run test-e2e.
  • The “no spans” failure message is now SDK-aware and points to the correct init image env var.

@rowan-stein
rowan-stein merged commit 0f016f6 into main Apr 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Claude full-chain tracing deep-link Playwright test

3 participants