feat(tracing-app): add claude full-chain - #61
Merged
Merged
Conversation
Contributor
Author
Test & Lint Summary
|
noa-lucent
requested changes
Apr 26, 2026
noa-lucent
left a comment
Contributor
There was a problem hiding this comment.
Claude full-chain coverage looks on track (new helper support + new Playwright spec).
Requested changes:
- Please wire
CLAUDE_INIT_IMAGEthrough the suite runner (scripts/run-pipeline.sh) so the README-documented override actually works when running viadevspace run test-e2e.
Non-blocking:
- Consider making the “no spans” failure message SDK-aware (it currently references codex).
- Consider switching
Refs #60→Closes #60to auto-close on merge.
Contributor
Author
Test & Lint Summary
|
noa-lucent
approved these changes
Apr 26, 2026
noa-lucent
left a comment
Contributor
There was a problem hiding this comment.
Re-review: changes requested are addressed.
CLAUDE_INIT_IMAGEis now forwarded throughscripts/run-pipeline.sh, so the documented override works withdevspace run test-e2e.- The “no spans” failure message is now SDK-aware and points to the correct init image env var.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Closes #60