Add DeleteOrganizationResources - #12
Open
vitramir wants to merge 1 commit into
Open
Conversation
Step 7 of the organization teardown: the groups an organization owns, after the private-resource grants that named them as principals are gone. The delete path is the one DeleteGroup already used -- tuples first, then the row, then the events -- so a group leaves through the same door however it is removed. The handler is internal and has no permission check; the Istio policy settles that Organizations is the only caller. Listing then deleting makes it idempotent: a retried step finds nothing and succeeds, which is what lets the cascade retry a step it is unsure finished.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 7 of the organization teardown: the groups an organization owns, deleted after the private-resource grants that named them as principals are gone.
Reuses the delete path
DeleteGroupalready had — admin and membership tuples first, then the row, then the events — rather than adding a second one that skips those steps.DeleteGroupkeeps itsrequireOrganizationOwnercheck and both now call the samedeleteGrouphelper.The RPC is internal: no OpenFGA check and no caller identity, gated by a new Istio
AuthorizationPolicythat admits only theorganizationsServiceAccount.Idempotent — listing then deleting means a retried step finds nothing and succeeds, which is what lets the cascade retry a step it is unsure finished.
Also adds the
DeleteOrganizationResourcesstub to the identity fake client, sinceidentity.protogained the same RPC.Chart bumped to 0.3.0 for the new template.
Part of organization settings and deletion.