Skip to content

Improve los customizability - #152

Merged
gomezzz merged 8 commits into
mainfrom
improve-LOS-customizability
Feb 28, 2023
Merged

gomezzz merged 8 commits into
mainfrom
improve-LOS-customizability

Conversation

@gomezzz

@gomezzz gomezzz commented Feb 27, 2023

Copy link
Copy Markdown
Collaborator

Description

Summary of changes

  • Added cfg parameter to allow setting radius of the sphere blocking line of sight
  • Changed default radius to 6451km
  • Some minor refactoring to account for the change
  • Minor string changes

Resolved Issues

How Has This Been Tested?

CI/CD

Related Pull Requests

N/A

Comment thread paseos/resources/default_cfg.toml Outdated
Comment thread paseos/tests/line_of_sight_test.py Outdated
central_body=earth,
)

sat1.set_central_body_shape(Sphere([0, 0, 0], 6371000))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

earth_radius = 6371000

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made it a constant in test_utils instead ✌️

@johanos1
johanos1 self-requested a review February 27, 2023 16:00
@gomezzz
gomezzz requested review from johanos1 and removed request for johanos1 February 27, 2023 16:21
@gomezzz
gomezzz merged commit dd62a90 into main Feb 28, 2023
@gomezzz
gomezzz deleted the improve-LOS-customizability branch February 28, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inter-satellite link model

2 participants