Allow custom meshes & rotations - #182
Merged
Merged
Conversation
GabrieleMeoni
approved these changes
Jul 18, 2023
schuhmaj
approved these changes
Aug 6, 2023
schuhmaj
left a comment
There was a problem hiding this comment.
Great work! I like that some of the previous free functions moved inside the actor class - which facilities the usage for the user. The CentralBody class and associated functions look fine as well.
Otherwise some minor comments for the wine 🍷algorithm. (and to the already pointed out magic number, but now in the test cases)
| # Load the 67P mesh with pickle | ||
| with open(mesh_path, "rb") as f: | ||
| mesh_points, mesh_triangles = pickle.load(f) | ||
| mesh_points = np.array(mesh_points) * 3126.6064453124995 # Scale to m |
There was a problem hiding this comment.
Magic Scaling number as a constant to the top of the file?
Collaborator
Author
There was a problem hiding this comment.
added a comment ✌️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
get_communication_window.pyfor readabilityResolved Issues
How Has This Been Tested?
Related Pull Requests
N/A
Visualization with mesh looks like this

@schuhmaj @rasmusmarak Your comments would also be appreciated 🙏
ToDos