Add option to configure host - #66
Conversation
ljharb
left a comment
There was a problem hiding this comment.
Is 0.0.0.0 the current default?
|
@ljharb yep! Express uses http.Server.listen() (https://expressjs.com/en/api.html#app.listen) |
|
Instead of hardcoding the default, maybe it'd be better to have a default of |
|
@ljharb Yeah sounds better, I'll do that. Couple of things I wanted to ask you:
Thanks! |
|
I prefer doing our own typechecking if possible. If there's an issue with async tests, a separate PR to fix it, merged first, would be ideal. |
|
@magicmark would you mind rebasing on the command line, instead of clicking "update branch" on the github ui? |
|
@ljharb sure. I haven't touched this branch in a while though. (waiting to finish another branch to refactor the integration test so I can write a test for this change) |
@ljharb that was me, my bad! |
f53980c to
8dd1f0c
Compare
We'd like to be able to configure the host that express binds to.
This new config option passes it along, and defaults to
0.0.0.0.