Skip to content

feat: strengthen C# edit workflow#108

Merged
akiojin merged 17 commits into
developfrom
feature/issue-107
Mar 10, 2026
Merged

feat: strengthen C# edit workflow#108
akiojin merged 17 commits into
developfrom
feature/issue-107

Conversation

@akiojin

@akiojin akiojin commented Mar 10, 2026

Copy link
Copy Markdown
Owner

Summary

  • strengthen the C# edit workflow so write tools use LSP by default and return a unified structured result
  • add write_csharp_file, create_csharp_file, apply_csharp_edits, plus singular project/package setting APIs
  • harden Unity batch/test behavior by skipping the TCP listener in batch/test processes and aligning EditMode test discovery

Testing

  • cargo clippy --all-targets -- -D warnings
  • cargo test --all-targets
  • dotnet test lsp/Server.Tests.csproj
  • dotnet build UnityCliBridge/UnityCliBridge.Editor.csproj
  • dotnet build UnityCliBridge/UnityCliBridge.Tests.csproj
  • Unity EditMode tests: 145 total / 139 passed / 0 failed / 6 skipped

Fixes #107

akiojin and others added 11 commits February 24, 2026 19:44
fix(ci): use PAT only for auto-merge to enable closing keywords
Bumps the npm_and_yarn group with 2 updates in the / directory: [@hono/node-server](https://github.com/honojs/node-server) and [hono](https://github.com/honojs/hono).


Updates `@hono/node-server` from 1.19.9 to 1.19.10
- [Release notes](https://github.com/honojs/node-server/releases)
- [Commits](honojs/node-server@v1.19.9...v1.19.10)

Updates `hono` from 4.12.3 to 4.12.5
- [Release notes](https://github.com/honojs/hono/releases)
- [Commits](honojs/hono@v4.12.3...v4.12.5)

---
updated-dependencies:
- dependency-name: "@hono/node-server"
  dependency-version: 1.19.10
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: hono
  dependency-version: 4.12.5
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Mar 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: bfedb477-64f3-4ce4-b86e-058dae719d99

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/issue-107

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@akiojin

akiojin commented Mar 10, 2026

Copy link
Copy Markdown
Owner Author

LSP Performance failure was caused by a transient GitHub release fetch error during unity-cli lsp install.

Fixed in 2403a6a:

  • retry transient 5xx and transport errors when fetching the csharp-lsp manifest in src/lsp_manager.rs
  • add unit coverage for 500->200 recovery and repeated 500 failure
  • merge the remote PR branch head so CI reruns on the current branch state

Verified locally:

  • cargo fmt --all -- --check
  • cargo clippy --all-targets -- -D warnings
  • cargo test --all-targets
  • cargo build --release
  • ./target/release/unity-cli lsp install --output json

CI is running again on PR #108.

@akiojin
akiojin merged commit c862b87 into develop Mar 10, 2026
17 checks passed
@akiojin
akiojin deleted the feature/issue-107 branch March 10, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant