Skip to content

chore(tooling): refresh claude settings and main pr triggers - #117

Merged
akiojin merged 5 commits into
developfrom
feature/refactor
Mar 11, 2026
Merged

chore(tooling): refresh claude settings and main pr triggers#117
akiojin merged 5 commits into
developfrom
feature/refactor

Conversation

@akiojin

@akiojin akiojin commented Mar 11, 2026

Copy link
Copy Markdown
Owner

Summary

  • Refresh .claude/settings.json so the local Claude/Codex environment uses the newer MCP, plugin, and hook configuration expected in this workspace.
  • Stop the generic Test workflow from running on develop -> main pull requests so main only enforces Main PR Policy instead of showing non-required failures.

Changes

  • .claude/settings.json: enabled the current project MCP/plugin set and updated hook wiring for the local Claude tooling configuration.
  • .github/workflows/test.yml: removed main from the pull_request branch trigger so the test workflow only runs for develop and feature PRs.

Testing

  • cargo test --all-targets — passes
  • cargo llvm-cov --all-targets --summary-only --fail-under-lines 90 — passes with total line coverage above 90%
  • npx --yes markdownlint-cli README.md CONTRIBUTING.md CLAUDE.md RELEASE.md docs/README.md docs/configuration.md docs/development.md docs/tools.md docs/benchmark-results.md docs/benchmark-results.ja.md docs/troubleshooting/README.md docs/troubleshooting/capabilities-none.md UnityCliBridge/Packages/unity-cli-bridge/**/*.md .github/workflows/README.md --config .markdownlint.json --ignore-path .markdownlintignore — passes

Related Issues / Links

  • None

Checklist

  • Tests added/updated
  • Lint/format passed (cargo clippy, cargo fmt, svelte-check) — svelte-check N/A: no Svelte project
  • Documentation updated (if user-facing change) — N/A: internal workflow and local tooling only
  • Migration/backfill plan included (if schema/data change) — N/A: no schema/data migration
  • CHANGELOG impact considered (breaking change flagged in commit) — N/A: no user-facing release note needed

Notes

@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c43d9261-1610-450e-841e-93b1cf2348cf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/refactor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter

codecov-commenter commented Mar 11, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@akiojin

akiojin commented Mar 11, 2026

Copy link
Copy Markdown
Owner Author

Fixed the blocking CI issues for this PR.

Done

  • Switched the LSP performance workflow from release-manifest installation to a local dotnet publish of the LSP server.
  • Updated scripts/lsp-perf-check.sh to reuse any local cached LSP install regardless of RID-specific subdirectory.
  • Re-ran cargo test --all-targets, cargo llvm-cov --all-targets --summary-only --fail-under-lines 90, and bash -n scripts/lsp-perf-check.sh locally.

Next

  • Waiting for the new CI run on commit 6f7c8c6 to complete.

@akiojin

akiojin commented Mar 11, 2026

Copy link
Copy Markdown
Owner Author

Fixed the remaining Rust CI flake.

Done

  • Reworked the lsp daemon stop test to wait for a successful stop response instead of timing-sensitive readiness polling.
  • Re-ran cargo test --all-targets locally after the change.

Next

  • Waiting for the new CI run on commit 2ad5e64 to complete.

@akiojin
akiojin merged commit 59eec6e into develop Mar 11, 2026
15 checks passed
@akiojin
akiojin deleted the feature/refactor branch March 11, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants