Skip to content

feat: apply GitHub repo settings and branch protection#15

Merged
github-actions[bot] merged 2 commits into
developfrom
feature/issue-10
Feb 17, 2026
Merged

feat: apply GitHub repo settings and branch protection#15
github-actions[bot] merged 2 commits into
developfrom
feature/issue-10

Conversation

@akiojin

@akiojin akiojin commented Feb 17, 2026

Copy link
Copy Markdown
Owner

Summary

Closes #10

  • develop.json: Fixed check names to match actual GitHub Actions job names (Rust Format & Lint, Markdown & Commitlint, Rust Tests (required), LSP Tests (required), Verify specs/specs.md is up-to-date)
  • Repo settings: Applied allow_auto_merge=true and delete_branch_on_merge=true via gh api
  • Branch protection: Applied main (Main PR Policy) and develop (5 CI checks) branch protection rules

Changes

File Change
.github/config/branch-protection/develop.json Updated check names to match actual workflow jobs
.github/config/README.md Added manual apply instructions, check name mapping, verification commands

Verification

```bash
gh api repos/akiojin/unity-cli | jq '{allow_auto_merge, delete_branch_on_merge}'
gh api repos/akiojin/unity-cli/branches/main/protection | jq '.required_status_checks.checks'
gh api repos/akiojin/unity-cli/branches/develop/protection | jq '.required_status_checks.checks'
```

Test plan

  • Repo settings verified: allow_auto_merge=true, delete_branch_on_merge=true
  • Main branch protection verified: Main PR Policy check required
  • Develop branch protection verified: 5 CI checks required

🤖 Generated with Claude Code

- Fix develop.json check names to match actual workflow job names
- Apply repo settings (allow_auto_merge, delete_branch_on_merge)
- Apply main/develop branch protection via gh api
- Update config README with manual apply instructions and check mapping

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Feb 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/issue-10

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
github-actions Bot enabled auto-merge February 17, 2026 04:53
@github-actions
github-actions Bot merged commit 18aee7b into develop Feb 17, 2026
11 checks passed
akiojin pushed a commit that referenced this pull request Mar 3, 2026
feat: apply GitHub repo settings and branch protection
@akiojin
akiojin deleted the feature/issue-10 branch April 14, 2026 04:12
arghhhhh added a commit to arghhhhh/unity-cli that referenced this pull request Jun 23, 2026
…ctor (akiojin#15)

Custom HLSL is now controllable end-to-end on both block and operator:
- inline source (m_HLSLCode) — already worked; now covered by tests
- external file: set m_ShaderFile to a .hlsl ShaderInclude path (reuses
  the Object-by-path coercion); the node sources from the file and its
  slots reshape to that function's signature
- function selector: m_AvailableFunction (block) / m_AvailableFunctions
  (operator) accept a bare function-name string. CoerceSettingValue now
  handles MultipleValuesChoice<T> (build instance + SetSelection), and
  ToJToken surfaces the selector as {selection, values} in describe.

All compose via existing set_block_setting/set_operator_setting — no new
op. Added a committed HLSLInclude.hlsl fixture (Squash → _factor).

Verified live + EditMode (3 behavioral; 96 passed, 0 failed/skipped; 0
Error-tier — slots resync FuncA→FuncB, OpA→OpB, and from the external
file). skill examples + prose updated.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
arghhhhh added a commit to arghhhhh/unity-cli that referenced this pull request Jun 24, 2026
…ojin#15)

Compose-only proofs over the existing m_HLSLCode/m_ShaderFile ops — the
package HLSLParser already resolves VFXSampler2D→Texture2D and
StructuredBuffer<T>→GraphicsBuffer slots (s_KnownTypes) and #include
directives (s_IncludeParser) when source is set, so no new code is
needed. Adds committed fixture HLSLMain.hlsl (which #includes the
existing HLSLInclude.hlsl) + two EditMode tests asserting the resolved
slot types and clean recompile. akiojin#15 Custom HLSL now complete — clears
the last niche Pass-2 tail box.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
arghhhhh added a commit to arghhhhh/unity-cli that referenced this pull request Jun 25, 2026
…ctor (akiojin#15)

Custom HLSL is now controllable end-to-end on both block and operator:
- inline source (m_HLSLCode) — already worked; now covered by tests
- external file: set m_ShaderFile to a .hlsl ShaderInclude path (reuses
  the Object-by-path coercion); the node sources from the file and its
  slots reshape to that function's signature
- function selector: m_AvailableFunction (block) / m_AvailableFunctions
  (operator) accept a bare function-name string. CoerceSettingValue now
  handles MultipleValuesChoice<T> (build instance + SetSelection), and
  ToJToken surfaces the selector as {selection, values} in describe.

All compose via existing set_block_setting/set_operator_setting — no new
op. Added a committed HLSLInclude.hlsl fixture (Squash → _factor).

Verified live + EditMode (3 behavioral; 96 passed, 0 failed/skipped; 0
Error-tier — slots resync FuncA→FuncB, OpA→OpB, and from the external
file). skill examples + prose updated.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
arghhhhh added a commit to arghhhhh/unity-cli that referenced this pull request Jun 25, 2026
…ojin#15)

Compose-only proofs over the existing m_HLSLCode/m_ShaderFile ops — the
package HLSLParser already resolves VFXSampler2D→Texture2D and
StructuredBuffer<T>→GraphicsBuffer slots (s_KnownTypes) and #include
directives (s_IncludeParser) when source is set, so no new code is
needed. Adds committed fixture HLSLMain.hlsl (which #includes the
existing HLSLInclude.hlsl) + two EditMode tests asserting the resolved
slot types and clean recompile. akiojin#15 Custom HLSL now complete — clears
the last niche Pass-2 tail box.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant