feat: apply GitHub repo settings and branch protection#15
Merged
Conversation
- Fix develop.json check names to match actual workflow job names - Apply repo settings (allow_auto_merge, delete_branch_on_merge) - Apply main/develop branch protection via gh api - Update config README with manual apply instructions and check mapping Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
akiojin
pushed a commit
that referenced
this pull request
Mar 3, 2026
feat: apply GitHub repo settings and branch protection
arghhhhh
added a commit
to arghhhhh/unity-cli
that referenced
this pull request
Jun 23, 2026
…ctor (akiojin#15) Custom HLSL is now controllable end-to-end on both block and operator: - inline source (m_HLSLCode) — already worked; now covered by tests - external file: set m_ShaderFile to a .hlsl ShaderInclude path (reuses the Object-by-path coercion); the node sources from the file and its slots reshape to that function's signature - function selector: m_AvailableFunction (block) / m_AvailableFunctions (operator) accept a bare function-name string. CoerceSettingValue now handles MultipleValuesChoice<T> (build instance + SetSelection), and ToJToken surfaces the selector as {selection, values} in describe. All compose via existing set_block_setting/set_operator_setting — no new op. Added a committed HLSLInclude.hlsl fixture (Squash → _factor). Verified live + EditMode (3 behavioral; 96 passed, 0 failed/skipped; 0 Error-tier — slots resync FuncA→FuncB, OpA→OpB, and from the external file). skill examples + prose updated. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
arghhhhh
added a commit
to arghhhhh/unity-cli
that referenced
this pull request
Jun 24, 2026
…ojin#15) Compose-only proofs over the existing m_HLSLCode/m_ShaderFile ops — the package HLSLParser already resolves VFXSampler2D→Texture2D and StructuredBuffer<T>→GraphicsBuffer slots (s_KnownTypes) and #include directives (s_IncludeParser) when source is set, so no new code is needed. Adds committed fixture HLSLMain.hlsl (which #includes the existing HLSLInclude.hlsl) + two EditMode tests asserting the resolved slot types and clean recompile. akiojin#15 Custom HLSL now complete — clears the last niche Pass-2 tail box. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
arghhhhh
added a commit
to arghhhhh/unity-cli
that referenced
this pull request
Jun 25, 2026
…ctor (akiojin#15) Custom HLSL is now controllable end-to-end on both block and operator: - inline source (m_HLSLCode) — already worked; now covered by tests - external file: set m_ShaderFile to a .hlsl ShaderInclude path (reuses the Object-by-path coercion); the node sources from the file and its slots reshape to that function's signature - function selector: m_AvailableFunction (block) / m_AvailableFunctions (operator) accept a bare function-name string. CoerceSettingValue now handles MultipleValuesChoice<T> (build instance + SetSelection), and ToJToken surfaces the selector as {selection, values} in describe. All compose via existing set_block_setting/set_operator_setting — no new op. Added a committed HLSLInclude.hlsl fixture (Squash → _factor). Verified live + EditMode (3 behavioral; 96 passed, 0 failed/skipped; 0 Error-tier — slots resync FuncA→FuncB, OpA→OpB, and from the external file). skill examples + prose updated. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
arghhhhh
added a commit
to arghhhhh/unity-cli
that referenced
this pull request
Jun 25, 2026
…ojin#15) Compose-only proofs over the existing m_HLSLCode/m_ShaderFile ops — the package HLSLParser already resolves VFXSampler2D→Texture2D and StructuredBuffer<T>→GraphicsBuffer slots (s_KnownTypes) and #include directives (s_IncludeParser) when source is set, so no new code is needed. Adds committed fixture HLSLMain.hlsl (which #includes the existing HLSLInclude.hlsl) + two EditMode tests asserting the resolved slot types and clean recompile. akiojin#15 Custom HLSL now complete — clears the last niche Pass-2 tail box. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #10
Rust Format & Lint,Markdown & Commitlint,Rust Tests (required),LSP Tests (required),Verify specs/specs.md is up-to-date)allow_auto_merge=trueanddelete_branch_on_merge=trueviagh apiMain PR Policy) and develop (5 CI checks) branch protection rulesChanges
.github/config/branch-protection/develop.json.github/config/README.mdVerification
```bash
gh api repos/akiojin/unity-cli | jq '{allow_auto_merge, delete_branch_on_merge}'
gh api repos/akiojin/unity-cli/branches/main/protection | jq '.required_status_checks.checks'
gh api repos/akiojin/unity-cli/branches/develop/protection | jq '.required_status_checks.checks'
```
Test plan
🤖 Generated with Claude Code