feat(test): migrate unity test project for unity-cli#17
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ct-migration # Conflicts: # README.md
akiojin
pushed a commit
that referenced
this pull request
Mar 3, 2026
feat(test): migrate unity test project for unity-cli
arghhhhh
added a commit
to arghhhhh/unity-cli
that referenced
this pull request
Jun 24, 2026
…iojin#17) New top-level tool (sibling of vfx_runtime/vfx_settings) for the SDF Bake Tool's programmatic path. Uses the package's PUBLIC MeshToSDFBaker (construct → BakeSDF → read back the 3D SdfTexture RenderTexture → save as a Texture3D asset). The package's own SaveToAsset is internal and goes through an interactive SaveFilePanel (headless blocker), so we do our own AsyncGPUReadback (per-layer, to capture all depth slices) + AssetDatabase.CreateAsset at the caller's path. Params: meshPath, outputPath, maxResolution, center/size (default mesh bounds), signPassCount, threshold, sdfOffset, overwrite. Guards on SystemInfo.supportsComputeShaders. Full 5-layer: catalog + host case + handler + EditMode tests (committed Cube.obj fixture; test Asserts.Ignore without compute) + skill v0.29.0 + docs. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
arghhhhh
added a commit
to arghhhhh/unity-cli
that referenced
this pull request
Jun 25, 2026
…iojin#17) New top-level tool (sibling of vfx_runtime/vfx_settings) for the SDF Bake Tool's programmatic path. Uses the package's PUBLIC MeshToSDFBaker (construct → BakeSDF → read back the 3D SdfTexture RenderTexture → save as a Texture3D asset). The package's own SaveToAsset is internal and goes through an interactive SaveFilePanel (headless blocker), so we do our own AsyncGPUReadback (per-layer, to capture all depth slices) + AssetDatabase.CreateAsset at the caller's path. Params: meshPath, outputPath, maxResolution, center/size (default mesh bounds), signPassCount, threshold, sdfOffset, overwrite. Guards on SystemInfo.supportsComputeShaders. Full 5-layer: catalog + host case + handler + EditMode tests (committed Cube.obj fixture; test Asserts.Ignore without compute) + skill v0.29.0 + docs. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnityCliBridge/TestProjectsounity-clican validate bridge behavior without depending on the legacy repository.com.akiojin.unity-cli-bridgeso runtime and editor code is exercised through the current package path.UnityMCPServer.*namespace references so migrated scenes and scripts continue to compile while transitioning toUnityCliBridge.*.Changes
UnityCliBridge/TestProject/**: added migrated Unity project assets,ProjectSettings, and package manifest for local reproducible Editor and E2E testing.UnityCliBridge/TestProject/Packages/manifest.json: addedcom.akiojin.unity-cli-bridgewithfile:../../Packages/unity-cli-bridgereference.UnityCliBridge/Packages/unity-cli-bridge/Runtime/IMGUI/LegacyMcpImguiControlRegistry.cs: added runtime compatibility bridge fromUnityMCPServer.Runtime.IMGUItoUnityCliBridge.Runtime.IMGUI.UnityCliBridge/Packages/unity-cli-bridge/Editor/Helpers/LegacyDebouncedAssetRefresh.cs: added editor helper compatibility bridge for legacy namespace calls.UnityCliBridge/Packages/unity-cli-bridge/Editor/Settings/LegacyUnityMcpServerProjectSettings.cs: added settings compatibility type for existing serialized project settings.UnityCliBridge/TestProject/Assets/Editor/UpmSigning/UpmPackSigner.cs: switched default package path toPackages/unity-cli-bridge.docs/development.mdandREADME.md: documented the new Unity test project location and batch EditMode test command.Testing
cargo fmt --all -- --check- passes with no formatting diffs.cargo clippy --all-targets --all-features -- -D warnings- passes with no warnings.cargo test --all-targets --all-features- passes (23 passed, 0 failed).dotnet test lsp/Server.Tests.csproj- N/A in this environment becausedotnetis not installed.Related Issues / Links
Checklist
cargo clippy,cargo fmt,svelte-check) -svelte-checkN/A: no Svelte sources in this repository.Context
unity-clilacked a full Unity test project withProjectSettings, which blocked end-to-end Unity validation from being self-contained.unity-cliand keeps compatibility shims so migration can proceed without immediate scene or script rewrites.Risk / Impact
dc07a2bto remove the test project and compatibility wrappers.Notes
mainbecausedevelopdoes not exist inakiojin/unity-cli.