Skip to content

docs(skills): unity-asset-management の get_asset_info action を明記 (#206)#214

Merged
akiojin merged 1 commit into
developfrom
work/issue-206
Jun 2, 2026
Merged

docs(skills): unity-asset-management の get_asset_info action を明記 (#206)#214
akiojin merged 1 commit into
developfrom
work/issue-206

Conversation

@akiojin

@akiojin akiojin commented Jun 2, 2026

Copy link
Copy Markdown
Owner

概要

unity-asset-management skill の Preferred Flow が manage_asset_database の有効な action を示しておらず、例も {"action":"refresh"} のみだったため、agent/user が未サポートの inspect action を推測しやすかった問題を修正する。

Closes #206

変更内容

  • Preferred Flow の手順1の文言を更新し、{"action":"get_asset_info","assetPath":"..."} を明記
  • コード例に get_asset_info の呼び出しを追加
  • metadata.version 0.3.0 → 0.3.1(doc/behavior 更新のため patch bump)

検証

  • 有効な action を一次情報で確認:
    • src/tooling/tool_catalog.rs: enum に get_asset_infoassetPath 必須)
    • UnityCliBridge/.../AssetDatabaseHandler.cs: case "get_asset_info"
  • cargo run -- skills lint --severity error15 skills checked, 0 violations
  • 変更は canonical SKILL.md のみ。.claude/skills/.agents/skills/ は canonical への symlink のため自動反映。

docs-only の skill markdown 変更のため、Rust/C# のビルド・テスト影響範囲外。

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation

    • Unity Asset Management スキルドキュメントをアップデートしました。
  • Chores

    • テスト実行の安定性向上のため、テストスレッド管理を最適化しました。
    • 開発環境の品質チェック手順を強化し、CI/ローカル環境での一貫性を確保しました。
    • 開発ワークフロー設定を追加し、プッシュ前の自動チェック機能を改善しました。

@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4235dd85-2f00-4744-9411-f3527f4e7013

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

This PR corrects the unity-asset-management skill documentation to specify proper asset inspection syntax, enforces serialized test execution to prevent environment race flakiness across CI and local quality gates, and installs Husky automation for pre-push format checking.

Changes

Project Quality and Testing Infrastructure

Layer / File(s) Summary
Unity Asset Management Skill Documentation Update
.claude-plugin/plugins/unity-cli/skills/unity-asset-management/SKILL.md
Skill version bumped to 0.3.1; "Preferred Flow" clarified to explicitly require manage_asset_database with {"action":"get_asset_info","assetPath":"..."} JSON payload for asset inspection before modifications.
Serialized Test Execution Configuration
.github/workflows/test.yml, CLAUDE.md, tasks/lessons.md
-- --test-threads=1 added to Rust test commands in CI workflow (cargo test and llvm-cov) and quality gate documentation; operational policy established that env-mutating tests must use env_lock without relying on parallelism, and env dependencies should be eliminated via argument injection where possible.
Husky Pre-push Hook Setup
package.json, .husky/pre-push
Husky (^9.1.7) installed as devDependency with prepare lifecycle script; pre-push hook configured to run cargo fmt --all -- --check only; heavy test execution (cargo test, dotnet test) removed from pre-push and delegated to CI.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

  • akiojin/unity-cli#160: The unity-asset-management SKILL.md version bump to 0.3.1 and explicit "Preferred Flow" requiring manage_asset_database get_asset_info action directly implement the SPEC's mandated SKILL.md restructuring checkpoint.

Poem

🐰✨ Tests now serialize, no env race today,
Hooked pre-push checks keep chaos at bay,
Skills speak plainly of assets to find,
Quality woven through CI design,
A leaner, more stable repository way!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning PR には #206 の主目的外の変更が含まれている。CI テスト並列化ルール、husky 統合、pre-push hook 変更、lessons.md ルール更新など、unity-asset-management ドキュメント更新とは無関係な変更がある。 主要な変更(unity-asset-management のドキュメント)は別 PR として分離し、CI/husky/ルール更新は独立した PR で管理することを推奨する。
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PRタイトルは、主な変更内容である unity-asset-management スキルドキュメントの get_asset_info action の明記を正確に反映している。
Linked Issues check ✅ Passed PR は #206 の全要件を満たしており、Preferred Flow を更新して get_asset_info の JSON ペイロード例を明記し、version を 0.3.0 → 0.3.1 に更新している。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch work/issue-206

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@akiojin

akiojin commented Jun 2, 2026

Copy link
Copy Markdown
Owner Author

Verification: ライブ Unity E2E(Overall: PASS)

docs-only 変更ですが、ドキュメントした get_asset_info コマンドが実在・動作することを、実際の Unity Editor に対して end-to-end で実証しました。

Check Command Result
happy path manage_asset_database {action:get_asset_info, assetPath:Assets/Scenes/SampleScene.unity} success:true(asset info 取得)
failure path(issue 再現) manage_asset_database {action:inspect, ...} ✅ enum error で reject
regression sanity manage_asset_database {action:refresh} success:true
  • 環境: batch-host headless Unity 6000.3.13f1(要求 6000.3.10f1 未インストールのため同 minor 代替), port 6402
  • 静的ゲート: unity-cli skills lint --severity error → 15 skills checked, 0 violations
  • ソース一次確認: tool_catalog.rs の action enum / AssetDatabaseHandler.cscase "get_asset_info"

検証で editor 起動により書き換わった manifest.json / packages-lock.json / ProjectVersion.txt は revert 済み、tree clean。

Closes #206

@akiojin
akiojin changed the base branch from main to develop June 2, 2026 10:49
Preferred Flow の "Inspect the target asset" 手順が `manage_asset_database`
の有効な action を示しておらず、例も `{"action":"refresh"}` のみだったため、
agent/user が未サポートの `inspect` action を推測しやすかった。

- 手順1の文言に `{"action":"get_asset_info","assetPath":"..."}` を明記
- コード例に get_asset_info の呼び出しを追加
- metadata.version 0.3.0 -> 0.3.1

有効な action は src/tooling/tool_catalog.rs と AssetDatabaseHandler.cs で
get_asset_info (assetPath 必須) を確認済み。skills lint --severity error は
0 violations。

Closes #206

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@akiojin
akiojin merged commit e4ddd79 into develop Jun 2, 2026
9 checks passed
@akiojin
akiojin deleted the work/issue-206 branch June 2, 2026 11:11
@akiojin akiojin mentioned this pull request Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unity-asset-management skill uses an invalid manage_asset_database action in its preferred flow

1 participant