Skip to content

feat(core): migrate runtime to unity-cli and add unityd daemon#33

Merged
github-actions[bot] merged 6 commits into
developfrom
feature/optimize-cli
Feb 23, 2026
Merged

feat(core): migrate runtime to unity-cli and add unityd daemon#33
github-actions[bot] merged 6 commits into
developfrom
feature/optimize-cli

Conversation

@akiojin

@akiojin akiojin commented Feb 23, 2026

Copy link
Copy Markdown
Owner

Summary

  • Migrate the repository baseline to unity-cli and remove remaining legacy MCP compatibility paths so maintenance converges on one Rust/TCP implementation.
  • Add unityd daemon lifecycle and batch execution paths in the CLI so repeated tool execution can reuse connections and reduce per-call overhead.
  • Restrict UNITY_CLI_UNITYD=auto fallback to transport failures only so daemon-reported tool failures are not executed a second time over direct TCP.

Changes

  • src/main.rs, src/config.rs, src/transport.rs, src/unityd.rs: add daemon command routing, batch call flow, UNITY_CLI_UNITYD mode handling, and transport-aware fallback/error classification.
  • src/lsp.rs, src/lsp_manager.rs: update LSP install/session behavior and retry/error handling for local code-index workflows.
  • UnityCliBridge/Packages/unity-cli-bridge/Editor/** and UnityCliBridge/Packages/unity-cli-bridge/Runtime/**: replace legacy MCP naming/paths, refresh handlers/settings/logging, and add missing metadata assets.
  • UnityCliBridge/Assets/Editor/UnityCliUiTestSceneGenerator.cs and docs/development.md: standardize generated E2E/UI scene output locations and test guidance.
  • .claude-plugin/plugins/unity-cli/skills/**, .codex/skills/**, README.md, CLAUDE.md, docs/**, specs/**: align skill distribution policy and migration/spec documentation with the unity-cli-only direction.

Testing

  • cargo fmt --all -- --check — exits with code 0.
  • cargo clippy --all-targets -- -D warnings — exits with code 0.
  • cargo test --all-targets — all tests passed (54 passed, 0 failed).
  • dotnet test lsp/Server.Tests.csproj — Not run in this session because this PR request was completed on the Rust CLI path only.

Related Issues / Links

  • None

Checklist

  • Tests added/updated
  • Lint/format passed (cargo clippy, cargo fmt, svelte-check) — svelte-check is N/A for this repository.
  • Documentation updated (if user-facing change)
  • Migration/backfill plan included (if schema/data change) — N/A: no schema/data migration was introduced.
  • CHANGELOG impact considered (breaking change flagged in commit)

Context

  • This branch contains the migration stream from legacy MCP-oriented assets/docs to unity-cli, plus the follow-up daemon fallback fix needed to prevent duplicate side effects after daemon-reported command errors.

Risk / Impact

  • Affected areas: Rust CLI command dispatch (src/main.rs), daemon transport (src/unityd.rs), Unity bridge editor handlers/settings, and migration/usage documentation.
  • Rollback plan: Revert this PR merge commit to restore prior command routing and docs state; no persistent data migration rollback is required.

@github-actions
github-actions Bot enabled auto-merge February 23, 2026 10:05
@coderabbitai

coderabbitai Bot commented Feb 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/optimize-cli

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@akiojin

akiojin commented Feb 23, 2026

Copy link
Copy Markdown
Owner Author

CI failures were addressed in commits 61db17a and 54baeaa. Local verification completed with: cargo fmt --all -- --check, cargo clippy --all-targets -- -D warnings, cargo test --all-targets. Required PR checks are now passing.

@github-actions
github-actions Bot merged commit 852dd29 into develop Feb 23, 2026
11 checks passed
@akiojin

akiojin commented Feb 23, 2026

Copy link
Copy Markdown
Owner Author

Resolved develop merge conflicts (notably in src/lspd.rs) and pushed commits 657a19a + 96ece51.

Re-ran local verification with:

  • cargo fmt --all -- --check
  • cargo clippy --all-targets -- -D warnings
  • cargo test --all-targets

Required PR checks are passing.

akiojin pushed a commit that referenced this pull request Mar 3, 2026
feat(core): migrate runtime to unity-cli and add unityd daemon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant