Skip to content

fix(lsp): preserve safe defaults and actionable errors - #41

Merged
akiojin merged 1 commit into
developfrom
feature/issue-40
Feb 25, 2026
Merged

fix(lsp): preserve safe defaults and actionable errors#41
akiojin merged 1 commit into
developfrom
feature/issue-40

Conversation

@akiojin

@akiojin akiojin commented Feb 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • Updated src/lsp.rs remove-symbol request building to omit failOnReferences when unset so backend reference checks stay enabled by default.
  • Updated src/local_tools.rs local LSP write fallback to execute directly in auto/required modes so actionable backend errors are not masked by a generic message.
  • Updated src/local_tools.rs class generation to add using UnityEngine; for MonoBehaviour inheritance and added regression tests to keep generated Unity scripts compilable.

Changes

  • src/lsp.rs: Changed handle_remove_symbol to preserve backend defaults for failOnReferences and added request-construction tests.
  • src/local_tools.rs: Changed local_lsp_write fallback behavior to propagate direct LSP errors in auto/required modes.
  • src/local_tools.rs: Changed local_create_class to emit using UnityEngine; for inherits: "MonoBehaviour" and updated class-generation tests.

Testing

  • cargo fmt — formatter completed successfully.
  • cargo test — 57 passed, 0 failed.

Related Issues / Links

Checklist

  • Tests added/updated
  • Lint/format passed (cargo clippy, cargo fmt, svelte-check) — cargo fmt passed; cargo clippy and svelte-check were not run in this PR.
  • Documentation updated (if user-facing change) — N/A: internal CLI/LSP behavior change only.
  • Migration/backfill plan included (if schema/data change) — N/A: no schema or data changes.
  • CHANGELOG impact considered (breaking change flagged in commit)

@coderabbitai

coderabbitai Bot commented Feb 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/issue-40

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@akiojin
akiojin merged commit a85037a into develop Feb 25, 2026
12 checks passed
@akiojin
akiojin deleted the feature/issue-40 branch February 25, 2026 09:03
akiojin added a commit that referenced this pull request Mar 3, 2026
fix(lsp): preserve safe defaults and actionable errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant