fix(lsp): preserve safe defaults and actionable errors - #41
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
akiojin
added a commit
that referenced
this pull request
Mar 3, 2026
fix(lsp): preserve safe defaults and actionable errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/lsp.rsremove-symbol request building to omitfailOnReferenceswhen unset so backend reference checks stay enabled by default.src/local_tools.rslocal LSP write fallback to execute directly inauto/requiredmodes so actionable backend errors are not masked by a generic message.src/local_tools.rsclass generation to addusing UnityEngine;forMonoBehaviourinheritance and added regression tests to keep generated Unity scripts compilable.Changes
src/lsp.rs: Changedhandle_remove_symbolto preserve backend defaults forfailOnReferencesand added request-construction tests.src/local_tools.rs: Changedlocal_lsp_writefallback behavior to propagate direct LSP errors inauto/requiredmodes.src/local_tools.rs: Changedlocal_create_classto emitusing UnityEngine;forinherits: "MonoBehaviour"and updated class-generation tests.Testing
cargo fmt— formatter completed successfully.cargo test— 57 passed, 0 failed.Related Issues / Links
Checklist
cargo clippy,cargo fmt,svelte-check) —cargo fmtpassed;cargo clippyandsvelte-checkwere not run in this PR.