fix: cross-platform path mismatch in capture handlers#55
Merged
Conversation
When unity-cli runs on Linux (Docker) and connects to a Windows Unity host,
workspaceRoot from Linux is invalid on Windows, and Path.Combine produces
backslash-separated paths that break JSON responses.
- Add IsLocalPath guard to reject foreign-OS paths and fallback to local resolution
- Normalize all output paths with .Replace('\\', '/') for consistent forward slashes
- Align ResolveWorkspaceRoot in Screenshot/Video/Profiler handlers with UnityCliBridgeHost
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
akiojin
added a commit
that referenced
this pull request
Mar 3, 2026
fix: cross-platform path mismatch in capture handlers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unity-cli→ Windows ホスト Unity でcapture_screenshot/capture_video_startの返却パスが不整合になる問題を修正 (Docker(Linux) 呼び出し + Windows Unity ホストでキャプチャ出力パスが不整合(ファイルが見えない) #54)IsLocalPathガードで異OS パス(Linux→Windows, Windows→Linux)をフォールバック.Replace('\\', '/')でフォワードスラッシュに統一ResolveWorkspaceRootをUnityCliBridgeHost版と統一Changed Files
ScreenshotHandler.csVideoCaptureHandler.csProfilerHandler.csTest plan
cargo fmt --all -- --check— passcargo clippy --all-targets -- -D warnings— passcargo test --all-targets— 132/132 passCloses #54
🤖 Generated with Claude Code