fix(bridge): run_tests / get_test_status / get_compilation_state の不整合修正 - #60
Merged
Conversation
…lter and watchdog (#59) - CompilationHandler: errorCount now reflects only script-compile errors (mode bit 0x1000), not Debug.LogError/Firebase/ADB console noise. Added consoleErrorCount/consoleWarningCount for full console counts. - TestExecutionHandler: filter routes to groupNames (class name) vs testNames (FQN) based on dot presence. - Watchdog: mode-aware timeouts (PlayMode 10s, EditMode 60s, general 120s). Persisted running state exceeding 120s staleness returns RUNNER_TIMEOUT. - SaveRunState: lastUpdate always set to DateTime.UtcNow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5 tasks
akiojin
added a commit
that referenced
this pull request
Mar 3, 2026
fix(bridge): run_tests / get_test_status / get_compilation_state の不整合修正
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #59
CompilationHandler.GetErrorCounts()でモードビット0x1000(script compile error) のエントリのみをerrorCountとしてカウント。Debug.LogError()や Firebase/ADB 等の Console エラーはconsoleErrorCountに分離。run_testsが誤ってブロックされる問題を修正filterにドットが含まれる場合はtestNames(FQN 正確一致)、含まれない場合はgroupNames(クラス名マッチ)を使用running状態が 120 秒超でRUNNER_TIMEOUTを返してクリアlastUpdateを常にDateTime.UtcNowに設定し、スタレネス判定の精度を確保Changed files
CompilationHandler.csGetConsoleCounts()→GetErrorCounts(), 新フィールド追加TestExecutionHandler.csCompilationHandlerTests.csTestExecutionHandlerWatchdogTests.csTestExecutionHandlerPersistenceTests.csTest plan
cargo fmt --all -- --check✅cargo clippy --all-targets -- -D warnings✅cargo test --all-targets(132/132 passed) ✅Debug.LogError("test")→get_compilation_stateでerrorCount: 0,consoleErrorCount: 1を確認run_tests(filter="クラス名")でクラス単位のテスト実行を確認get_test_statusがcompletedに遷移することを確認🤖 Generated with Claude Code