fix: prod build update time error#111
Merged
Merged
Conversation
yangxiaolang
temporarily deployed
to
translate
January 19, 2026 06:22 — with
GitHub Actions
Inactive
Contributor
WalkthroughAdded a Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.build/build.yaml:
- Around line 98-99: Replace the blind "git fetch --unshallow || true" with a
conditional that first checks shallow status (e.g., using "git rev-parse
--is-shallow-repository") and only attempts "git fetch --unshallow" when needed;
capture the fetch exit code and emit a warning log if the fetch fails so the
pipeline logs clearly indicate the last-modified-time fix may not apply.
Specifically, locate the step containing the literal "git fetch --unshallow ||
true" and change it to: detect shallow repo, run "git fetch --unshallow" if
shallow, and on non-zero exit emit a warning message clarifying the fetch failed
and that file last-modified timestamps may be inaccurate.
- Around line 83-90: The extraction of host and path from git remote URLs fails
for scp-style remotes (e.g., git@github.com:org/repo.git); update the logic that
sets host and path (the host=... and path=... assignments used before invoking
/katanomi/bin/ktn-task copy git) to detect whether the remote URL contains "://"
and use the existing sed rules for HTTP/HTTPS, otherwise handle scp-style by
stripping the optional user@ prefix, replacing the ':' separator with '/',
removing any ".git" suffix and any "@..." ref suffix, and then set host to the
hostname portion and path to the repo path (so ktn-task copy git
--server=${host} --scope-prefix=${path} receives correct values).
yangxiaolang
temporarily deployed
to
translate
January 19, 2026 06:51 — with
GitHub Actions
Inactive
yangxiaolang
temporarily deployed
to
translate
January 19, 2026 07:08 — with
GitHub Actions
Inactive
yangxiaolang
force-pushed
the
fix/prod-build-update-time-error
branch
from
January 19, 2026 07:32
ee407a6 to
b128db9
Compare
yangxiaolang
temporarily deployed
to
translate
January 19, 2026 07:32 — with
GitHub Actions
Inactive
zlcnju
approved these changes
Jan 19, 2026
shibalu
approved these changes
Jan 21, 2026
changluyi
pushed a commit
to changluyi/knowledge
that referenced
this pull request
Apr 23, 2026
* feat: order by update time * chore: update ci for correct update time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Chores
New Features
✏️ Tip: You can customize this high-level summary in your review settings.