Preserve DTLS 1.3 client key shares on cookie-only retries - #163
Merged
Merged
Conversation
JoTurk
marked this pull request as draft
September 18, 2026 11:15
JoTurk
force-pushed
the
jo/fix-cookie-retry
branch
from
September 18, 2026 11:35
3c08caa to
4c86862
Compare
JoTurk
marked this pull request as ready for review
September 18, 2026 11:42
Owner
|
Looks great! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the DTLS 1.3 client's existing key exchange when a HelloRetryRequest contains only a cookie, keeping the second ClientHello's key share unchanged and allowing handshakes with servers that enforce this requirement. Continue generating a new key exchange when the retry selects a key exchange group.
Add regression coverage for key-share preservation and a complete cookie-only retry handshake with wolfSSL. Use OpenSSL certificate helpers so the cookie tests run in both crypto-provider CI configurations, and document the fix in the changelog.