Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Support watching sub-expressions (JSON values) as is done for function parameters #16

Description

@caitp

Cross-referencing angular/angular.js#7663

Basically, we do this already for function paramters, it needs to happen for JSON values too.

In fact, if a JSON literal expression contains non-const expressions, then most likely we should exclusively be watching the subexpressions, and not the JSON object itself --- so that we don't end up replacing the whole object and creating garbage.

We already do this for PureFunctionAST (and I don't think this should be removed as cargo cult), so we ought to do it for JSON literal properties too. I can't recall if we're already doing that, but I don't believe we have tests for it. I'll check

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions