Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Selectors - #1

Closed
EisenbergEffect wants to merge 9 commits into
angular:masterfrom
EisenbergEffect:selectors
Closed

EisenbergEffect wants to merge 9 commits into
angular:masterfrom
EisenbergEffect:selectors

Conversation

@EisenbergEffect

Copy link
Copy Markdown
Contributor

Ok. Here's the port of the Selectors code from Dart over to ES6 using the new API design. There were two sets of tests that seemed to test the same thing. I ported one of those sets (and made some improvements). All the original tests for selectors are now passing. I can certainly add additional tests and I think we will want to, but this gets things going and proves that the selectors are indeed working.

@EisenbergEffect

Copy link
Copy Markdown
Contributor Author

PS. Sorry that took so long. This week was full of distractions that pulled me away from my work on this project. They were related to commitments I made before starting this job (a couple of guest lectures I committed to doing for FSU's CS department). That said, those things are now wrapped up so hopefully tasks like this will go quicker in the future.

Comment thread src/selector.js Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation seem off

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right! That must have happened when I was shuffling my code around and copy/pasting.

@caitp

caitp commented Mar 7, 2014

Copy link
Copy Markdown
Contributor

I don't have time right now to give a proper review, but I was wondering if it might also make sense to add selectors for XML namespaces, to assist in supporting SVG and MathML stuff? I guess if we need that it could be added later on, but it seems like a good idea

@tbosch

tbosch commented Mar 7, 2014

Copy link
Copy Markdown
Contributor

Thanks Rob,
landed in master as 8958370.

I did some refactorings:

  • moved the selector modules into the subfolder "selector"
  • simplified the implementation by moving source parts around
  • implemented the correct behavior for text nodes, so that {{..}} is correctly recognized.
  • as well as for bind-, on- and attr={{...}} attributes.

@tbosch tbosch closed this Mar 7, 2014
@tbosch

tbosch commented Mar 7, 2014

Copy link
Copy Markdown
Contributor

@caitp Could you create an issue for this so we can keep track of it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants