Repository navigation
Selectors - #1
EisenbergEffect wants to merge 9 commits into
Conversation
|
PS. Sorry that took so long. This week was full of distractions that pulled me away from my work on this project. They were related to commitments I made before starting this job (a couple of guest lectures I committed to doing for FSU's CS department). That said, those things are now wrapped up so hopefully tasks like this will go quicker in the future. |
There was a problem hiding this comment.
You're right! That must have happened when I was shuffling my code around and copy/pasting.
|
I don't have time right now to give a proper review, but I was wondering if it might also make sense to add selectors for XML namespaces, to assist in supporting SVG and MathML stuff? I guess if we need that it could be added later on, but it seems like a good idea |
|
Thanks Rob, I did some refactorings:
|
|
@caitp Could you create an issue for this so we can keep track of it? |
Ok. Here's the port of the Selectors code from Dart over to ES6 using the new API design. There were two sets of tests that seemed to test the same thing. I ported one of those sets (and made some improvements). All the original tests for selectors are now passing. I can certainly add additional tests and I think we will want to, but this gets things going and proves that the selectors are indeed working.