Skip to content

feat: add session.turn.completed bus event for plugin hooks - #23650

Closed
xbjpku wants to merge 2 commits into
anomalyco:devfrom
xbjpku:plugin-hooks
Closed

feat: add session.turn.completed bus event for plugin hooks#23650
xbjpku wants to merge 2 commits into
anomalyco:devfrom
xbjpku:plugin-hooks

Conversation

@xbjpku

@xbjpku xbjpku commented Apr 21, 2026

Copy link
Copy Markdown

Issue for this PR

Closes #23503

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Adds a session.turn.completed bus event that fires at the end of each assistant turn — after all tool calls finish, before compaction runs.

Why: I'm building a filesystem sandbox plugin (ScarletWitch) that needs to know when a turn ends so it can query COW state and show a review dialog. The existing plugin hooks don't cover this timing:

  • tool.execute.after fires per tool call, not per turn — showing a dialog mid-turn would interrupt the LLM
  • No existing bus event signals turn completion
  • chat.message fires on message receipt, not after tool execution finishes

The change is +9 lines across 2 files:

  • session/session.ts (+6): Define Session.Event.TurnCompleted with sessionID payload
  • session/prompt.ts (+3): yield* bus.publish(Session.Event.TurnCompleted, { sessionID }) after the runLoop exits

Zero breaking changes — the event is additive. Existing code is unaffected.

How did you verify your code works?

  • Tested with the ScarletWitch-opencode-plugin: server plugin receives the event via the event hook, TUI plugin receives it via api.event.on(), COW review dialog shows correctly after each turn
  • Verified the event fires at the right time (after all tool calls, before compaction) by checking supervisor logs

Screenshots / recordings

N/A — this is a backend event, no UI change.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. and removed needs:compliance This means the issue will auto-close after 2 hours. labels Apr 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: add session.turn.completed bus event for plugin hooks

1 participant