fix(codex): exclude -pro models from ChatGPT-account model list - #32612
Closed
devinoldenburg wants to merge 4 commits into
Closed
fix(codex): exclude -pro models from ChatGPT-account model list#32612devinoldenburg wants to merge 4 commits into
-pro models from ChatGPT-account model list#32612devinoldenburg wants to merge 4 commits into
Conversation
The OAuth model filter auto-allows any `gpt-<version>` model newer than 5.4 via a version heuristic. That heuristic lets `gpt-5.5-pro` (and other `-pro` variants) appear as available for ChatGPT-account (OAuth) sessions, but the Codex backend does not serve `-pro` models to ChatGPT accounts — they are API-key only. Selecting one fails at request time with: Bad Request: The 'gpt-5.5-pro' model is not supported when using Codex with a ChatGPT account. Extract the filter predicate into `isModelSupportedForChatGPTAccount` and exclude `*-pro` ids from the heuristic path so these models no longer show up as options for OAuth accounts. Explicitly allow-listed ids still take precedence, so a future `-pro` model can be re-enabled by adding it there if OpenAI starts serving it. Fixes #26115
Address review feedback: `parseFloat` mis-orders multi-digit minor versions (e.g. "5.10" parses as 5.1), so `gpt-5.10` would be wrongly excluded by the `> 5.4` heuristic. Capture major and minor separately and compare as integers. Added a regression test for the multi-digit minor case.
This was referenced Jun 17, 2026
This was referenced Jun 18, 2026
Collaborator
|
closing in favor of simple solution |
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.