Skip to content

fix(app): restore timeline scroll position - #33943

Closed
Brendonovich wants to merge 3 commits into
devfrom
timeline-scroll-state
Closed

fix(app): restore timeline scroll position#33943
Brendonovich wants to merge 3 commits into
devfrom
timeline-scroll-state

Conversation

@Brendonovich

@Brendonovich Brendonovich commented Jun 25, 2026

Copy link
Copy Markdown
Member

Summary

  • persist each session timeline position through the existing debounced layout scroll store
  • restore the exact visible virtual row and viewport offset across titlebar tab switches and reloads
  • load older history when newer messages shift the latest page
  • cancel restoration on user input and recover cleanly from history loading failures
  • preserve message-hash navigation and latest-message bottom anchoring precedence
  • add smoke coverage for exact row restoration across tabs and after appending 240 messages

Validation

  • bun typecheck from packages/app
  • focused layout-scroll and hash-scroll unit tests: 6 passed
  • exact-row titlebar switch and shifted-history reload smoke test passed
  • production timeline streaming benchmark passed with no geometry drift or remounts

Benchmark

  • baseline completion: 60.7s; long-task time: 14.0s
  • latest completion: 57.0s; long-task time: 10.0s
  • machine-dependent measurements; no regression observed

@Brendonovich
Brendonovich requested a review from Hona as a code owner June 25, 2026 17:40
@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant