fix(desktop): handle missing file list directories - #34073
Closed
OpeOginni wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #27056
Type of change
What does this PR do?
Issue:
When git diff contains deleted files, the Changes file tree still needs to render their original paths. To do that, it creates synthetic parent directory nodes, even though that directory may no longer exist on disk. When the synthetic directory is expanded, the frontend calls
file.listfor that path. The server then calls realPath on the missing directory, gets ENOENT, converts it to a defect, and returns a 500.Fix:
How did you verify your code works?
Added a server test for missing directories returning 404, regenerated SDK types, and ran focused tests/typechecks.
Screenshots / recordings
Checklist