feat(tui): clear prompt input on double escape - #35036
Closed
azizbecha wants to merge 2 commits into
Closed
Conversation
6 tasks
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes # — no existing issue for this one. Related: #14037 asked for Claude Code double-esc parity (restore menu) before being stale-closed; this PR covers a different piece, clearing the input. Happy to open an issue first if that's preferred given the feature guardrail in CONTRIBUTING.
Type of change
What does this PR do?
Pressing esc twice quickly (within 500ms) clears the prompt input. Today esc does nothing in the prompt while the session is idle, and ctrl+c is the only way to clear it.
It reuses the two patterns that already exist for this:
session.interruptuses for esc-esc while busy (counter in the prompt store + timeout reset), with a footer hint "esc again to clear" after the first press, styled like the existing "esc again to interrupt" hintclearPrompt()path, so the cleared draft is appended to prompt history and recoverable with up-arrow, exactly like ctrl+cThe binding is a new configurable keybind
input_clear_double(defaultescape, set"none"to disable) mapped to a newprompt.clear.doublecommand. Its enabled gate makes it mutually exclusive with every other escape claimant: only fires when the session is idle (esc while busy still interrupts and never touches the text), prompt non-empty, normal mode, no autocomplete popup, no dialog. Escape-cancels-pending-leader-sequence behavior is untouched.How did you verify your code works?
packages/tui/test/cli/tui/prompt-clear.test.tsxmounts the realPromptcomponent with the full provider stack and drives real key events through the keymap: double-esc clears and the draft is restorable from history via up-arrow, the footer hint appears/disappears, a second esc after 600ms does not clear,input_clear_double: "none"disables the feature, and a busy session (via asession.statusevent) keeps the interrupt behavior with text intact.test/keymap.test.tsx(compiles toescape, disable works).bun testinpackages/tui: 196 pass, 0 fail.bun run typecheckclean.Screenshots / recordings
Captured frame from the integration test after the first esc press:
Checklist