Skip to content

fix(opencode): settle pending tool errors - #35268

Closed
opencode-agent[bot] wants to merge 1 commit into
devfrom
pending-tool-error
Closed

fix(opencode): settle pending tool errors#35268
opencode-agent[bot] wants to merge 1 commit into
devfrom
pending-tool-error

Conversation

@opencode-agent

@opencode-agent opencode-agent Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • settle tool errors even when the AI SDK emits tool-error before tool-call promotes the part from pending to running
  • preserve the actual tool failure instead of replacing it with cleanup's Tool execution aborted marker
  • add a deterministic processor regression covering the event ordering

Why

MCP isError results began rejecting in #32244. The AI SDK may publish the resulting tool-error while the tool part is still pending. failToolCall previously ignored that state and left its deferred unsettled, which can strand the provider turn.

Verification

  • bun test test/session/processor-effect.test.ts (16 pass)
  • bun typecheck in packages/opencode
  • git diff --check

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant