fix(llm): serialize overlapping OpenAI reasoning - #37022
Open
xiaodream551-a11y wants to merge 1 commit into
Open
fix(llm): serialize overlapping OpenAI reasoning#37022xiaodream551-a11y wants to merge 1 commit into
xiaodream551-a11y wants to merge 1 commit into
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
|
The linked issue is #36892 and the PR template now references it as |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #36892
Type of change
What does this PR do?
OpenAI Responses can start another reasoning summary before the previous item has fully ended. V2 persists one reasoning block at a time, so those overlapping starts terminate the run with
reasoning start before end.This serializes overlapping reasoning events before publishing them, while retaining text/tool order and final encrypted continuation metadata. Reused provider block IDs are isolated so late deltas cannot merge into an earlier block.
How did you verify your code works?
bun run testinpackages/llm(319 passed, 29 skipped).bun run typecheckinpackages/llmandpackages/core.bun turbo typecheck --concurrency=3hook passed across 32 packages.Screenshots / recordings
Not applicable; this is a non-UI stream parser fix.
Checklist