Skip to content

fix(core): resolve npm edge by package name instead of first entry - #39019

Closed
AAliKKhan wants to merge 1 commit into
anomalyco:devfrom
AAliKKhan:fix-npm-edge-lookup
Closed

fix(core): resolve npm edge by package name instead of first entry#39019
AAliKKhan wants to merge 1 commit into
anomalyco:devfrom
AAliKKhan:fix-npm-edge-lookup

Conversation

@AAliKKhan

Copy link
Copy Markdown

When installing an npm package with peer dependencies, \ ree.edgesOut.values().next().value\ can return the peer dependency's edge instead of the installed package's edge because Map iteration follows insertion order.\n\nThis causes \Npm.add()\ to return the wrong package's path and name (the peer dependency), or fall through to the error path even when the install succeeded.\n\nFix: look up the edge by package name (\ ree.edgesOut.get(name)) instead of grabbing the first entry.

@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. needs:issue labels Jul 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

The search found PR #39019 (the current PR itself) but no other related duplicate PRs. The only other result (#21697) is about npmrc configuration, which is unrelated to this edge resolution fix.

No duplicate PRs found

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Jul 27, 2026
@github-actions github-actions Bot closed this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant