Skip to content

fix(app): defer model variant selector - #39445

Merged
Brendonovich merged 3 commits into
devfrom
variant-selector-visibility
Jul 29, 2026
Merged

fix(app): defer model variant selector#39445
Brendonovich merged 3 commits into
devfrom
variant-selector-visibility

Conversation

@Brendonovich

@Brendonovich Brendonovich commented Jul 29, 2026

Copy link
Copy Markdown
Member

Summary

  • hide the model variant UI while model data is loading
  • keep the variant controller available throughout loading

Validation

  • bun typecheck in packages/app
  • bun run typecheck in packages/session-ui
  • bun test src/v2/components/prompt-input in packages/session-ui
  • bun run test:e2e -- e2e/user-story/model-selection-flow.spec.ts in packages/app
  • repository pre-push typecheck

@Brendonovich
Brendonovich requested a review from Hona as a code owner July 29, 2026 03:32
@Brendonovich
Brendonovich enabled auto-merge (squash) July 29, 2026 04:23
@Brendonovich
Brendonovich merged commit e8b0992 into dev Jul 29, 2026
14 of 15 checks passed
@Brendonovich
Brendonovich deleted the variant-selector-visibility branch July 29, 2026 05:16
3kaiu pushed a commit to 3kaiu/opencode-x that referenced this pull request Jul 31, 2026
1056674754 added a commit to 1056674754/opencode that referenced this pull request Aug 5, 2026
Upstream v1.18.9 (4da7bb4) -> v1.18.10 (7902e04), 24 commits.

Functional changes:
- feat: discover Modal models (anomalyco#39066) - new packages/opencode/src/plugin/modal/
- fix: use OpenCode model catalog URL (anomalyco#39672) - models.dev -> models.opencode.ai
- fix(app): repair malformed persisted tabs (anomalyco#39645)
- fix(app): defer model variant selector (anomalyco#39445)
- fix(app): preserve agent picker for existing users (anomalyco#39300)
- feat(app): migrate to solid-sonner (anomalyco#39519)
- feat(app): attachment fades, duplicate guard, always-visible new session button
- feat(app): review tab top bar + tab state refinements
- fix(console): add public fetch compatibility flag
- docs(ecosystem): add opencode-tavily plugin (anomalyco#38709)
- chore: bump gitlab-ai-provider to 6.12.1 (anomalyco#39490)

Conflicts resolved: 29 package.json version bumps (rebranded 1.18.10-sscity)
and bun.lock (regenerated). No functional code conflicts.

Verified: Modal plugin tests pass (2/2), model catalog URL applied to all
3 files, fork-only changes (small_model_fallback, skill hot-reload, server
single-flight) intact. Pre-existing TUI type errors unrelated to this merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant