fix: make revert boundaries chronological - #42461
opencode-agent[bot] wants to merge 1 commit into
Conversation
|
Good catch — comparing message IDs lexically ( One behavior change worth a closer look:
LGTM modulo the not-found edge case above. |
|
|
I tested the missing-message case mentioned above. It still causes problems on current OpenCode loads long conversations a page at a time. If the message selected for undo is on an older page that has not loaded yet, the App and TUI can keep showing messages that the undo should hide. Pressing undo again can also fail when the selected message is the first message on the current page. OpenCode needs the message before it, but that message is still on the previous page. I added tests and fixes on Would you prefer that I separate this message-loading fix and add it to |
|
Replaced by #46974. That PR is based on current |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Summary
Checks
bun test src/context/server-session.test.ts(packages/app)bun test test/cli/tui/data.test.tsx test/cli/tui/session-rows.test.ts(packages/tui)bun typecheck(packages/app)bun typecheck(packages/tui)bun test ./e2e/performance/unit(packages/app; 45 pass before/after)Requested by: @thdxr (Dax via Slack)