Skip to content

fix(provider): ignore SSE comment heartbeats for chunk timeout - #43607

Closed
1052326311 wants to merge 3 commits into
anomalyco:devfrom
1052326311:fix/43519-sse-comment-timeout
Closed

fix(provider): ignore SSE comment heartbeats for chunk timeout#43607
1052326311 wants to merge 3 commits into
anomalyco:devfrom
1052326311:fix/43519-sse-comment-timeout

Conversation

@1052326311

@1052326311 1052326311 commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Issue for this PR

Closes #43519

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

chunkTimeout currently restarts for every response body read. SSE comment frames such as : keepalive therefore prevent an otherwise stalled model stream from timing out. This keeps one deadline across reads and resets it only after a complete SSE event containing data:. Header timeouts and non-SSE responses are unchanged.

The regression uses the existing loopback OpenAI-compatible server: it sends one data event, then comment heartbeats every 20 ms. With a 50 ms timeout, the stream must produce the existing typed response-stream error.

How did you verify your code works?

  • PR base: 3a31c4ea801915c0b050df4b3842997ea62b6e93
  • Current head: 8de252f7aed6b8fc4d93a650be397fd385c7c433
  • Provider timeout tests: 7 passed
  • Package typecheck: passed
  • Repository pre-push typecheck: 30/30 tasks passed
  • Standards and compliance checks: passed

The upstream test, typecheck, and nix-eval workflows require maintainer approval for this fork head.

Screenshots / recordings

Not applicable; this is a provider timeout fix.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. and removed needs:compliance This means the issue will auto-close after 2 hours. labels Aug 20, 2026
@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@1052326311

1052326311 commented Aug 20, 2026

Copy link
Copy Markdown
Author

Current head b9234e31edc25d9f1334b27aaf9b4dd9c918484f is mergeable and the repository duplicate, standards, and compliance checks are green. The loopback SSE regression exercises the provider boundary without external credentials. Please review this exact head.

@neriousy neriousy mentioned this pull request Aug 20, 2026
Merged
@1052326311

1052326311 commented Aug 21, 2026

Copy link
Copy Markdown
Author

Follow-up head 8de252f7aed6b8fc4d93a650be397fd385c7c433 closes two exact-head validation gaps: the regression now handles the existing stream error part/throw behavior, and the deadline is narrowed safely for TypeScript. On the repository-pinned Bun 1.3.14, the provider timeout file passes 7/7; package typecheck and the pre-push repository typecheck (30/30 tasks) pass. Upstream test, typecheck, and nix-eval remain action_required pending maintainer approval.

renekris added a commit to renekris/opencode-lowmem that referenced this pull request Aug 22, 2026
@renekris
fix(opencode): provider stream reliability (ports of upstream anomaly…
ebc1594 
…co#42150 anomalyco#42176 anomalyco#43881 anomalyco#43607)

- O(N) text/reasoning delta accumulation instead of O(N^2) string
  concat (anomalyco#42150) — the lazy chunk buffer joins on read
- finish reason 'error' is set when a stream fails mid-flight (anomalyco#42176)
- clean-EOF empty provider streams retry like transient errors (anomalyco#43881),
  narrowed from the upstream patch: only an attempt that produced no
  text/reasoning delta and no tool call qualifies, so providers that
  stream content but omit usage/finish are not retried into duplicate
  output
- SSE comment heartbeats no longer reset the chunk timeout (anomalyco#43607);
  the streaming TextDecoder handles multi-byte characters split across
  reads (regression covered)
This was referenced Aug 25, 2026
Closed
Closed
@totalolage totalolage mentioned this pull request Sep 6, 2026
Open
3 tasks done
@github-actions github-actions Bot mentioned this pull request Sep 9, 2026
Closed
3 of 6 tasks
@github-actions

github-actions Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

@github-actions github-actions Bot closed this Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

automated-pr-cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chunkTimeout resets on SSE comment heartbeats — keepalive-warm stalled streams never time out

1 participant

@1052326311