Conversation
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found a highly related PR: Related PR:
This PR is directly related because it also addresses Other potentially related PRs addressing prompt loop and stream handling: |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #43939
Type of change
What does this PR do?
#43892 keeps the prompt loop running on every
unknownfinish so an empty dropped stream can recover. Providers also label complete text turns asunknown. Those turns then start another generation, and if the next one isunknowntoo the loop never ends.This treats
unknownas done when the assistant already produced text and has no pending tool calls. Emptyunknownstill continues. Reasoning-onlyunknownstill continues so a later text turn can arrive.How did you verify your code works?
bun test ./test/session/prompt.test.ts -t unknown(empty unknown still recovers; text unknown settles; reasoning-only continues)bun test ./test/cli/run/run-process.test.ts -t unknownincluding the existing continuation tests and a newopencode runcase that must not consume a follow-up replybun typecheckinpackages/opencodeScreenshots / recordings
Not a UI change.
Checklist