Repository navigation
fix(opencode): report skipped plugins when no server entrypoint is found - #44372
AllanSantos-DV wants to merge 2 commits into
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Right fix for a real gap — previously a plugin whose entrypoint couldn't be resolved vanished silently, and this closes that while keeping the wording consistent with the existing compatibility-stage message ( Two small suggestions:
Otherwise good to merge. |
Skip messages now include where the plugin was declared (scope + config source) so a config-sourced and a local-file plugin failing for the same reason no longer read identically. Formatting lives in plugin/report.ts with a regression test pinning the wiring and the copy.
|
Thanks for the careful review! Both points applied in e0d30fd:
|
|
Both points look good - carrying the declaring origin into skip reports makes them actionable, and extracting the formatting behind regression tests keeps it stable. Verified e0d30fd covers both. Nothing further from me. |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #44367
Type of change
What does this PR do?
In the server plugin loader, the
missingreport callback was empty — an npm plugin whose package has no detectable server entrypoint was dropped with zero feedback, unlike install/compatibility/load failures which callpublishPluginError. This fills it in with the same pattern:Plugin <spec> skipped: Plugin <spec> does not expose a server entrypointHow did you verify your code works?
reportobject; no behavior change for successfully loaded plugins.tsc --noEmit: only pre-existing errors inpackages/tui/(unrelated to this file).Checklist