Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: Related PRs FoundThe current PR (#44806) has several related PRs addressing similar issues with provider responses and session recovery:
Most notably, #41898 appears to be the most closely related, as it addresses the specific issue of failing on empty assistant responses rather than silently recording them as success. |
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
e74c2d1 to
d5b058f
Compare
2b3fc45 to
0e960a3
Compare
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #42677
Type of change
What does this PR do?
A provider can stop or fail after producing only reasoning or whitespace, leaving the session with no answer or tool call. OpenCode currently treats some of these attempts as successful and ends the run silently.
This change tracks whether an attempt produced a non-whitespace answer or any tool activity. A normal stop that reports output tokens but no usable content gets one bounded continuation. A provider failure after reasoning or whitespace uses the existing bounded incomplete-stream recovery path. Failures after visible text or tool activity remain terminal so completed work is not replayed.
How did you verify your code works?
bun test test/session-runner.test.ts --timeout 30000inpackages/core(Bun 1.3.14; 178 pass)bun run typecheckinpackages/coreScreenshots / recordings
Not a UI change.
Checklist