Repository navigation
refactor(core): consolidate model error mapping - #45722
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Generate maps three ModelResolver failure tags through identical explicit-versus-implicit selection logic. Effect supports catching a non-empty tag list with one narrowed handler.
What Changes
Replaces the three duplicate handlers with one multi-tag
catchTaghandler. Explicit model requests still fail withModelSelectionError; implicit resolution still fails withUnavailableErrorcarrying the resolver provider ID.Scope
The no-model fallback, AI generation error mapping, and separate Integration authorization message remain unchanged. PR #45398 also touches
generate.tsfor Bedrock region behavior but does not consolidate these resolver handlers.Verification
Core typecheck passed, all 41 focused tests passed, and oxlint reported no warnings or errors. The push hook completed the 33-package workspace typecheck.