Repository navigation
fix(core): retry acknowledged websocket read failures - #49183
Merged
Merged
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
nexxeln
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #48690
Type of change
What does this PR do?
A provider acknowledgment marks a WebSocket request as accepted before assistant output necessarily starts. If the socket then closes with 1006, the retry policy rejects it, while partial-output continuation has not become eligible, so the session fails.
Allow accepted read failures through the existing retry policy. Before output, the runner retries with bounded backoff; after output, it continues from durable history. Explicit request rejections keep their existing handling.
How did you verify your code works?
Screenshots / recordings
Not applicable (retry logic).
Checklist