Repository navigation
fix(codemode): coerce any value to a property key - #50479
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ToPropertyKey: a key that is not already a string, number, or one of the two confined symbols becomes its string form, as in JS.
o[null]iso["null"],o[true]iso["true"],o[{}]iso["[object Object]"],o[[1, 2]]iso["1,2"]. Applies to reads, writes, compound assignment, object literals,in, and computed destructuring keys — they all go through the onetoPropertyKey.coerceToStringis the existing built-in-aware one (Date→ ISO string,Promise→[object Promise]); a program object's owntoStringis not consulted yet — that is the ToPrimitive PR.Tests
Seven
skipped.txtentries removed (Array/prototype/{every,filter,forEach,map,reduce,reduceRight,some}tests that index with an object key).