fix(ui): fix desktop theme background seeds, light contrast, and token typos - #50517
Merged
Merged
Conversation
Add missing '#' prefix to icon-weak-base in oc-2.json to ensure valid CSS variable resolution at computed-value time, fixing missing SVG icon shadows and logo fills. Signed-off-by: Omkar Chandorkar <gotenksIN@aospa.co>
Fix the light neutral background seed by replacing Mocha Rosewater (#f5e0dc) with Latte Base (#eff1f5), removing the unintended pink tint on desktop neutral surfaces. Align diff colors, syntax constants, and comments with official Latte tokens, and fix green and yellow typos in the Mocha dark palette. Source: https://catppuccin.com/palette/ Signed-off-by: Omkar Chandorkar <gotenksIN@aospa.co>
Replace duplicated dark palette and dark overrides in the light variant with official Catppuccin Latte tokens to resolve severe contrast collapse (from 2.05:1 to 9.34:1). Correct Frappe Blue and comment hex typos in the dark variant. Source: https://catppuccin.com/palette/ Signed-off-by: Omkar Chandorkar <gotenksIN@aospa.co>
Replace duplicated dark palette and dark overrides in the light variant with official Catppuccin Latte tokens to resolve severe contrast collapse (from 1.95:1 to 9.34:1) in desktop light mode. Source: https://catppuccin.com/palette/ Signed-off-by: Omkar Chandorkar <gotenksIN@aospa.co>
Replace dark Wave syntax overrides in Kanagawa's light variant with official Kanagawa Lotus tokens to resolve low-contrast syntax text against the light background. Source: https://github.com/rebelot/kanagawa.nvim Signed-off-by: Omkar Chandorkar <gotenksIN@aospa.co>
Update green luminance weight from 0.587 to the standard ITU-R BT.709 coefficient 0.7152 in contrastRatio() to ensure accurate WCAG relative luminance calculation. Signed-off-by: Omkar Chandorkar <gotenksIN@aospa.co>
3 of 6 tasks
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #50500
Type of change
What does this PR do?
This PR fixes background seed defects, contrast collapses in light mode, and syntax typos across desktop themes and the theme calculation helper:
OC-2 (
oc-2.json):#prefix to"icon-weak-base": "#C7C7C7"(line 28) so CSS variables resolve correctly at computed-value time, fixing missing SVG icon shadows and logo fills.Catppuccin (
catppuccin.json):#f5e0dc) with official Latte Base (#eff1f5) inlight.palette.neutral, eliminating the pink/flesh wash across desktop surfaces.diffAdd: #40a02b,diffDelete: #d20f39), syntax constant (#fe640b), and comments (#6c6f85).#f9e2af) and green success (#a6e3a1).Catppuccin Frappé & Macchiato (
catppuccin-frappe.json,catppuccin-macchiato.json):#8da4e2->#8caaee) and comment (#949cb8->#949cbb) hex typos.Kanagawa (
kanagawa.json):#6f894e,#cc6d00,#624c83,#4d699b,#b35b79,#8a8980) to resolve low-contrast syntax text against the light Lotus background.Luminance Formula (
color.ts):contrastRatio(), updated the green luminance weight from0.587to the standard ITU-R BT.709 coefficient0.7152for accurate WCAG relative luminance calculations.How did you verify your code works?
bun test src/theme/v2/resolve.test.ts(9/9 pass).packages/ui/src/theme/desktop-theme.schema.json.Screenshots / recordings
Before (Catppuccin Light pink wash):
After (Fixed with official Latte Base
#eff1f5):Checklist
AI Assistant Disclosure: This pull request was prepared with assistance from OpenCode (GPT-6 Astra).