fix(tui): preserve explicit config during migration - #50846
Open
sdivyanshu90 wants to merge 1 commit into
Open
sdivyanshu90 wants to merge 1 commit into
sdivyanshu90 wants to merge 1 commit into
Conversation
Author
|
Hi @thdxr @jlongster, could you please review this PR whenever you have some time. Thanks! |
This was referenced Sep 27, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #50842
Type of change
What does this PR do?
TUI migration included the file selected by
OPENCODE_CONFIG, wrote its TUI settings to an adjacenttui.json, and stripped the original file even though the TUI loader intentionally does not read that adjacent path. This limits migration to the normal config search paths, preserving arbitrary explicit config files for users to migrate withOPENCODE_TUI_CONFIG.How did you verify your code works?
themeandkeybindsand creates neithertui.jsonnor a migration backup for an externalOPENCODE_CONFIGfile.packages/opencode:bun test test/config/tui.test.ts— 34 passed, 3 Windows-only skipped, 0 failed on Bun 1.3.14.packages/opencode:bun typecheckproduced no diagnostics but did not complete after several minutes in this environment and was stopped.packages/console/function/src/auth-redirect.test.tsbecausebun:testtypes could not be resolved; the push was completed with Husky skipped.Screenshots / recordings
Not applicable; this is configuration migration logic.
Checklist