Repository navigation
fix(app): validate comment selection coordinates - #51322
Open
sdivyanshu90 wants to merge 1 commit into
Open
sdivyanshu90 wants to merge 1 commit into
sdivyanshu90 wants to merge 1 commit into
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Author
|
Hi @Hona, could you please review this PR whenever you have some time? Thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #51319
Type of change
What does this PR do?
Requires all four comment selection coordinates to already be finite numbers before constructing a selection. Malformed coordinates such as
nullare ignored instead of being coerced to line zero, while the rest of the comment metadata remains available.How did you verify your code works?
Added focused tests for null coordinates and a valid numeric selection, then ran the comment-note unit test from
packages/app: 2 tests passed with 3 assertions.Screenshots / recordings
Not applicable; this is a non-UI metadata parsing fix.
Checklist